Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add githooks to project #5

Merged
merged 1 commit into from
Sep 19, 2020

Conversation

mkeoliya
Copy link
Collaborator

Reason: Improve developer productivity, and prevent pushing code with bugs.

Adds a pre-push hook that runs the following gradle tasks: test, clean, checkstyleMain and checkstyleTest. Did not add a pre-commit hook so that developers can cut down on commit time.

Secured approval via this issue filed on the GitHub forum for CS2103.

Copy link

@JingYenLoh JingYenLoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Tested locally and it works. Should the developer guide be updated as well? We have not started on that, but I believe inserting a section would help us.

@JingYenLoh
Copy link

As discussed in our team meeting this week, @mkeoliya and I will be updating the Developer Guide. We will include a note about the git hooks when we do that.

@JingYenLoh JingYenLoh merged commit 43c5826 into AY2021S1-CS2103-T16-3:master Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants