Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Person to Student class #71

Merged
merged 4 commits into from
Sep 25, 2020
Merged

Modify Person to Student class #71

merged 4 commits into from
Sep 25, 2020

Conversation

mkeoliya
Copy link
Collaborator

@mkeoliya mkeoliya commented Sep 24, 2020 •
edited

Changes:

  • Rename all instances of Person with Student
  • Add 2 attributes to the Student model
    • Faculty (contains 17 possible options defined in FacultyEnum)
    • StudentId (unique student identifier, of the form E0<6-digits>)

Fixes #72

@mkeoliya mkeoliya added this to the v1.2 milestone Sep 25, 2020
Lysire
Lysire approved these changes Sep 25, 2020
View reviewed changes
Copy link

@Lysire Lysire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Lysire Lysire merged commit e96669c into AY2021S1-CS2103-T16-3:master Sep 25, 2020
@mkeoliya mkeoliya mentioned this pull request Oct 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lysire Lysire Lysire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Add Student model to ResiReg
2 participants
@mkeoliya @Lysire