Jy/view vacant rooms #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also implement the vacant rooms command, since it came free with the modifications.
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
============================================
- Coverage 65.57% 59.18% -6.40%
- Complexity 450 454 +4
============================================
Files 85 92 +7
Lines 1592 1781 +189
Branches 182 215 +33
============================================
+ Hits 1044 1054 +10
- Misses 486 660 +174
- Partials 62 67 +5
Continue to review full report at Codecov.
|
Problem: There is a cyclic dependency between Room and Student - they contain each other. This causes serialization and toString to stackoverflow. Current Solution: Modify their toString not to contain each other, and create additional classes for Jackson to Serialize (JsonAdaptedRoomStudent and JsonAdaptedStudentRoom). This solution isn't ideal, but it produces working code. I'd be happy to accept alternatives.
|
Requesting 2 reviewers for this 😠 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
This PR adds the ability to view vacant rooms with a flag
--vacant.While working on this, I identified several issues.
Additionally, we never had a UI for displaying rooms, although the models were mostly working underneath. I've added a tabbed based UI for them. Depending on the command, it should navigate to the correct tab. For example,
roomsshould automatically switch to the Rooms tab.I'm currently fixing a bug where the Rooms are not saved. I will unmark this as a draft when that is done.EDIT: I have come up with code that works. However, it involves creating additional classes for serialization, which I don't find ideal (see cbd0b8d). I'd be happy to accept suggestions, although I doubt I can implement it before v1.2 closes.