-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Logic.java, LogicManager.java, Model.java, ModelManager.java #124
Update Logic.java, LogicManager.java, Model.java, ModelManager.java #124
Conversation
…into TapBar_branch # Conflicts: # src/main/java/seedu/address/MainApp.java # src/main/java/seedu/address/model/Model.java # src/main/java/seedu/address/model/ModelManager.java # src/test/java/seedu/address/logic/LogicManagerTest.java # src/test/java/seedu/address/logic/commands/AddCommandIntegrationTest.java # src/test/java/seedu/address/logic/commands/AddCommandTest.java # src/test/java/seedu/address/logic/commands/ClearCommandTest.java # src/test/java/seedu/address/logic/commands/DeleteCommandTest.java # src/test/java/seedu/address/logic/commands/EditCommandTest.java # src/test/java/seedu/address/logic/commands/FindCommandTest.java # src/test/java/seedu/address/logic/commands/ListCommandTest.java # src/test/java/seedu/address/model/ModelManagerTest.java
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
============================================
+ Coverage 45.12% 45.62% +0.50%
- Complexity 523 536 +13
============================================
Files 140 140
Lines 2531 2558 +27
Branches 264 266 +2
============================================
+ Hits 1142 1167 +25
+ Misses 1342 1336 -6
- Partials 47 55 +8
Continue to review full report at Codecov.
|
@@ -149,4 +152,46 @@ | |||
*/ | |||
void updateFilteredPropertyList(Predicate<Property> predicate); | |||
|
|||
//=========== ModelManager ================================================================================ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MeetingManager?
setTabBar(); | ||
populateTab(); | ||
} | ||
|
||
/** | ||
* Initialises all tabs on the tabpane. | ||
*/ | ||
|
||
private void setPersonCalenderBidTabBar() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge this with setTabBar()
|
||
private Logic logic; | ||
|
||
@FXML | ||
private TabPane personCalenderBidTabBar; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove this line
…into TapBar_branch # Conflicts: # src/main/java/seedu/address/MainApp.java # src/main/java/seedu/address/logic/Logic.java # src/main/java/seedu/address/logic/LogicManager.java # src/main/java/seedu/address/model/ModelManager.java # src/main/java/seedu/address/ui/TabBar.java # src/test/java/seedu/address/logic/LogicManagerTest.java # src/test/java/seedu/address/logic/commands/AddCommandIntegrationTest.java # src/test/java/seedu/address/logic/commands/AddCommandTest.java # src/test/java/seedu/address/logic/commands/ClearCommandTest.java # src/test/java/seedu/address/logic/commands/DeleteCommandTest.java # src/test/java/seedu/address/logic/commands/EditCommandTest.java # src/test/java/seedu/address/logic/commands/FindCommandTest.java # src/test/java/seedu/address/logic/commands/ListCommandTest.java # src/test/java/seedu/address/model/ModelManagerTest.java
@@ -138,6 +140,15 @@ public Path getSellerAddressBookFilePath() { | |||
|
|||
// ===================== PROPERTY ===================== | |||
|
|||
@Override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should organise by the comment headers
No description provided.