Add Commands and Parsers for Meetings, Fix Error Messages for Invalid Commands #127

Christopher-LM · 2020-10-12T10:21:27Z

No description provided.

# Conflicts: # src/main/java/seedu/address/logic/parser/AddressBookParser.java

codecov-io · 2020-10-12T10:23:03Z

Codecov Report

Merging #127 into master will decrease coverage by 0.90%.
The diff coverage is 3.61%.

@@             Coverage Diff              @@
##             master     #127      +/-   ##
============================================
- Coverage     45.62%   44.71%   -0.91%     
  Complexity      536      536              
============================================
  Files           140      145       +5     
  Lines          2558     2612      +54     
  Branches        266      270       +4     
============================================
+ Hits           1167     1168       +1     
- Misses         1336     1389      +53     
  Partials         55       55

Impacted Files	Coverage Δ	Complexity Δ
...main/java/seedu/address/commons/core/Messages.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...eedu/address/logic/commands/AddMeetingCommand.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...u/address/logic/commands/DeleteMeetingCommand.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...edu/address/logic/commands/ListMeetingCommand.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
.../address/logic/parser/AddMeetingCommandParser.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
.../seedu/address/logic/parser/AddressBookParser.java	`61.53% <0.00%> (-5.13%)`	`12.00 <0.00> (ø)`
...dress/logic/parser/DeleteMeetingCommandParser.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...in/java/seedu/address/logic/parser/ParserUtil.java	`49.01% <0.00%> (+4.37%)`	`10.00 <0.00> (ø)`
...va/seedu/address/model/calendar/CalendarAdmin.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
.../seedu/address/model/calendar/CalendarMeeting.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf7c3d...07a0d91. Read the comment docs.

dianneloh9 · 2020-10-12T12:45:59Z

src/main/java/seedu/address/logic/parser/AddMeetingCommandParser.java

-        Person person = new Person(name, phone, tagList);
-
-        return new AddCommand(person);
+        if (type.contains("p")) {


Can use static variables here, eg PREFIX_PAPERWORK = "p"

dianneloh9 · 2020-10-12T12:57:06Z

src/main/java/seedu/address/model/calendar/UniqueMeetingList.java

@@ -94,7 +93,7 @@ public void setMeetings(seedu.address.model.calendar.UniqueMeetingList replaceme
     */
    public void setMeetings(List<CalendarMeeting> meetings) {
        requireAllNonNull(meetings);
-        if (!propertiesAreUnique(meetings)) {
+        if (!meetingsAreUnique(meetings)) {


Christopher-LM added 2 commits October 12, 2020 16:25

Add Commands and Parsers

8fc8a38

Merge branch 'master' of https://github.com/AY2021S1-CS2103-W14-1/tp

07a0d91

# Conflicts: # src/main/java/seedu/address/logic/parser/AddressBookParser.java

Christopher-LM added type.Task type.Enhancement.Meetings priority.Medium labels Oct 12, 2020

Christopher-LM added this to the v1.2 milestone Oct 12, 2020

Christopher-LM self-assigned this Oct 12, 2020

dianneloh9 approved these changes Oct 12, 2020

View reviewed changes

dianneloh9 merged commit befbd21 into AY2021S1-CS2103-W14-1:master Oct 12, 2020

This was linked to issues Oct 13, 2020

As a busy REA, I want to create meetings #103

Closed

create AddCommandBuyerParser and AddCommandSellerParser #59

Closed

Christopher-LM removed a link to an issue Oct 13, 2020

create AddCommandBuyerParser and AddCommandSellerParser #59

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Commands and Parsers for Meetings, Fix Error Messages for Invalid Commands #127

Add Commands and Parsers for Meetings, Fix Error Messages for Invalid Commands #127

Christopher-LM commented Oct 12, 2020

codecov-io commented Oct 12, 2020

dianneloh9 Oct 12, 2020 •

edited

dianneloh9 Oct 12, 2020

Add Commands and Parsers for Meetings, Fix Error Messages for Invalid Commands #127

Add Commands and Parsers for Meetings, Fix Error Messages for Invalid Commands #127

Conversation

Christopher-LM commented Oct 12, 2020

codecov-io commented Oct 12, 2020

Codecov Report

dianneloh9 Oct 12, 2020 • edited

Choose a reason for hiding this comment

dianneloh9 Oct 12, 2020

Choose a reason for hiding this comment

dianneloh9 Oct 12, 2020 •

edited