Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property unit tests #134

Merged

Conversation

dianneloh9
Copy link

No description provided.

@dianneloh9 dianneloh9 added this to the v1.2 milestone Oct 13, 2020
@dianneloh9 dianneloh9 self-assigned this Oct 13, 2020
@codecov-io
Copy link

codecov-io commented Oct 13, 2020

Codecov Report

Merging #134 into master will increase coverage by 7.78%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #134      +/-   ##
============================================
+ Coverage     43.48%   51.26%   +7.78%     
- Complexity      585      713     +128     
============================================
  Files           153      153              
  Lines          2946     2957      +11     
  Branches        315      317       +2     
============================================
+ Hits           1281     1516     +235     
+ Misses         1601     1362     -239     
- Partials         64       79      +15     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/logic/LogicManager.java 55.26% <ø> (ø) 3.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...eedu/address/model/propertybook/PropertyModel.java 100.00% <ø> (ø) 1.00 <0.00> (?)
.../java/seedu/address/model/util/SampleDataUtil.java 7.50% <ø> (ø) 1.00 <0.00> (ø)
...ain/java/seedu/address/storage/StorageManager.java 69.56% <ø> (ø) 19.00 <0.00> (ø)
...ress/storage/property/JsonPropertyBookStorage.java 47.61% <ø> (ø) 4.00 <0.00> (ø)
...storage/property/JsonSerializablePropertyBook.java 26.66% <ø> (ø) 1.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 52.28% <80.00%> (+7.69%) 37.00 <2.00> (+7.00)
...in/java/seedu/address/model/property/Property.java 91.04% <100.00%> (+91.04%) 29.00 <6.00> (+29.00)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9867d58...c019b30. Read the comment docs.

Copy link

@Marcon2509 Marcon2509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but where did my bid junit tests go i saw that it was removed from the addCommandTest

@kormingsoon kormingsoon merged commit fde0468 into AY2021S1-CS2103-W14-1:master Oct 13, 2020
import seedu.address.model.property.PropertyType;
import seedu.address.testutil.property.PropertyBuilder;

public class AddPropertyCommandParserTest {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The methods in this class seem very lengthy and perhaps you can consider abstracting or reducing the length to make it clearer for future readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants