-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property unit tests #134
Property unit tests #134
Conversation
…into property-unit-tests
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
============================================
+ Coverage 43.48% 51.26% +7.78%
- Complexity 585 713 +128
============================================
Files 153 153
Lines 2946 2957 +11
Branches 315 317 +2
============================================
+ Hits 1281 1516 +235
+ Misses 1601 1362 -239
- Partials 64 79 +15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but where did my bid junit tests go i saw that it was removed from the addCommandTest
import seedu.address.model.property.PropertyType; | ||
import seedu.address.testutil.property.PropertyBuilder; | ||
|
||
public class AddPropertyCommandParserTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The methods in this class seem very lengthy and perhaps you can consider abstracting or reducing the length to make it clearer for future readers.
No description provided.