Implement Bidder Seller JUNIT Command and Parser #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
============================================
+ Coverage 54.85% 59.09% +4.24%
- Complexity 783 857 +74
============================================
Files 158 161 +3
Lines 3019 3068 +49
Branches 332 338 +6
============================================
+ Hits 1656 1813 +157
+ Misses 1271 1162 -109
- Partials 92 93 +1
Continue to review full report at Codecov.
|
dianneloh9
approved these changes
Oct 15, 2020
| this.bidder = bidder; | ||
| } | ||
|
|
||
| @Override | ||
| public CommandResult execute(Model model) throws CommandException { | ||
| requireNonNull(model); | ||
|
|
||
| if (model.hasPerson(bidder)) { | ||
| if (model.hasBidder(bidder)) { | ||
| throw new CommandException(MESSAGE_DUPLICATE_PERSON); |
There was a problem hiding this comment.
Very small issue but MESSAGE_DUPLICATE_BIDDER?
| @FXML | ||
| private void setAutoTab(EntityType entityType) { | ||
| TabBar personAndJobTabPane = new TabBar(this.logic); | ||
| personAndJobTabPane.setTab(entityType); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.