Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG for bids, added Junit tests for bid storage and parser, added auto sort to EditBidCommand #200

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

Marcon2509
Copy link

updated the ug commands for bid

@Marcon2509 Marcon2509 added documentation Improvements or additions to documentation enhancement New feature or request type.Enhancements.Bids labels Oct 27, 2020
@Marcon2509 Marcon2509 added this to the v1.3b milestone Oct 27, 2020
@Marcon2509 Marcon2509 self-assigned this Oct 27, 2020
@codecov-io
Copy link

codecov-io commented Oct 27, 2020

Codecov Report

Merging #200 into master will increase coverage by 2.21%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #200      +/-   ##
============================================
+ Coverage     57.89%   60.10%   +2.21%     
- Complexity     1086     1122      +36     
============================================
  Files           203      203              
  Lines          4220     4224       +4     
  Branches        544      546       +2     
============================================
+ Hits           2443     2539      +96     
+ Misses         1623     1536      -87     
+ Partials        154      149       -5     
Impacted Files Coverage Δ Complexity Δ
...ress/logic/commands/bidcommands/AddBidCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...in/java/seedu/address/model/bid/UniqueBidList.java 85.36% <ø> (ø) 18.00 <0.00> (ø)
...main/java/seedu/address/model/bidbook/BidBook.java 88.00% <ø> (ø) 11.00 <0.00> (ø)
...ddress/model/bid/BidContainsKeywordsPredicate.java 81.81% <66.66%> (+4.04%) 10.00 <2.00> (+2.00)
...ess/logic/commands/bidcommands/EditBidCommand.java 86.20% <100.00%> (+1.99%) 13.00 <0.00> (+1.00)
...rc/main/java/seedu/address/model/ModelManager.java 76.47% <100.00%> (+0.25%) 62.00 <1.00> (ø)
src/main/java/seedu/address/model/bid/Bid.java 96.77% <100.00%> (ø) 17.00 <0.00> (ø)
...edu/address/storage/bidstorage/JsonAdaptedBid.java 100.00% <100.00%> (+62.50%) 8.00 <0.00> (+6.00)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c406dda...72dca4f. Read the comment docs.

@Marcon2509 Marcon2509 merged commit 5082f2b into AY2021S1-CS2103-W14-1:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request type.Enhancements.Bids
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants