Add Seller, Bidder, SellerAddressBook, BidderAddressBook, ReadOnlySellerAddressBook, ReadOnlyBidderAddressBook, UniqueSellerList, UniqueBidderList #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from Team Repo
…lerAddressBook, ReadOnlyBidderAddressBook, UniqueSellerList, UniqueBidderList
This was
linked to
issues
Oct 5, 2020
dianneloh9
approved these changes
Oct 5, 2020
| * Returns an unmodifiable view of the persons list. | ||
| * This list will not contain any duplicate persons. | ||
| */ | ||
| ObservableList<Bidder> getPersonList(); |
There was a problem hiding this comment.
Would getBidderList() be a better name? So that when you call this method, you know that you are getting a bidder list and likewise for seller list. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddressBook for bidder and seller still needs to be modified