Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor checkout archive #207

Conversation

shermz-lim
Copy link

No description provided.

@shermz-lim shermz-lim added this to the v1.4 milestone Nov 2, 2020
@shermz-lim shermz-lim self-assigned this Nov 2, 2020
@shermz-lim shermz-lim linked an issue Nov 2, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #207 into master will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #207   +/-   ##
=========================================
  Coverage     73.19%   73.19%           
  Complexity      831      831           
=========================================
  Files           121      121           
  Lines          2529     2529           
  Branches        314      314           
=========================================
  Hits           1851     1851           
  Misses          565      565           
  Partials        113      113           
Impacted Files Coverage Δ Complexity Δ
...ress/logic/parser/ArchiveBookingCommandParser.java 62.50% <66.66%> (ø) 3.00 <1.00> (?)
.../address/logic/commands/ArchiveBookingCommand.java 86.95% <87.50%> (ø) 9.00 <1.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 77.77% <100.00%> (ø) 17.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47bcaba...f7212fc. Read the comment docs.

@shermz-lim shermz-lim linked an issue Nov 2, 2020 that may be closed by this pull request
Copy link

@Hazel1603 Hazel1603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shermz-lim shermz-lim merged commit 26edf84 into AY2021S1-CS2103-W14-2:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor check out to archive booking [PE-D] Unclear definition of Active vs Inactive
3 participants