forked from nus-cs2103-AY2021S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding booking class #50
Merged
zeling595
merged 12 commits into
AY2021S1-CS2103-W14-2:master
from
SherryWu178:adding-booking
Oct 5, 2020
Merged
Adding booking class #50
zeling595
merged 12 commits into
AY2021S1-CS2103-W14-2:master
from
SherryWu178:adding-booking
Oct 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* commit 'eb9d58bacdd309643ec32403a5c038ca4f6e2d83': Fix typos in User Guide Update Ui.png mockup again Update index.md to update website Update first half of the User Guide
* commit 'e205b2e352b13ee2baf56bc10533716a35f6edc9': Update Use Cases Update DeveloperGuide.md Add listBooking in User Guide Update Use Cases in DeveloperGuide Update value proposition, target user profile, non-functional requirements, glossary Change checkin command so that it uses person's name and phone number Update User Stories
* commit 'a8d7bb46784d89f6aed3d60c044e85e935fe5772': Update gene.md Update hazel.md Update About Us Update hazel.md Update hazel.md Create zeling.md Update sherman.md Create gene.md Create hazel.md Delete johndoe.md Create sherman.md
* commit '8a2051c6e9a5e81f7a60249789760e9def6f8e34': Revert back image file names to usernames for hazel and sherry Fix case-renaming bug Fix AboutUs bug Change names in images to lower case letters
* commit 'cf1a29560ea4f8bc5531fcbed417439a36f6853d': Add test for hasPersonWithId Add hasPersonWithId method for model Fix checkstyle errors Update tests Change Person hasSamePerson to depend only on id Small fix for Person. Add comment in edit command Fix edit, storage and ui for new id field in Person Add id field to Person and initialize auto increment of id field
SherryWu178
force-pushed
the
adding-booking
branch
from
October 5, 2020 15:24
8975d04
to
f97a68b
Compare
* commit '9ab1987747469f7b3eb730786560b4bf7c9cd03c': Fix AddCommand Change minor Jacadocs Fix checkstyle Modify Model, Price, RoomID Pass checkstyle Clean up CheckInCommandParser parse method Clean up test Remove roomId checking in parser logic Minor modifications Minor modifications Pass CheckInCommandParserTest Implement CheckIn Parser Add Tests Fix checkstyle issues in Test Fix checkstyle issue Add newline at EOF of ReadOnlyRoomBook Add RoomBook Add Tests for CheckIn Command Add CheckInCommand class
* master: Fix AddCommand Change minor Jacadocs Fix checkstyle Modify Model, Price, RoomID Pass checkstyle Clean up CheckInCommandParser parse method Clean up test Remove roomId checking in parser logic Minor modifications Minor modifications Pass CheckInCommandParserTest Implement CheckIn Parser Add Tests Fix checkstyle issues in Test Fix checkstyle issue Add newline at EOF of ReadOnlyRoomBook Add RoomBook Add Tests for CheckIn Command Add CheckInCommand class
zeling595
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49