Exception messages updated to display aliases if any #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How come it only applies to RemarkCommand and EditCommand? |
|
Other command usage messages do not contain their respective |
|
Fix introduced is too hardcoded and not extensible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99
Fixed by catching and updating the exception message in the ExpenseBookParser before throwing out the same type of error with a new message. However, command string pattern used within the error messages themselves will also get replaced with this fix. Thus, invisible (non-printable) escape character ('\u200e') was injected for RemarkCommand.MESSAGE_USAGE and EditCommand.MESSAGE_NOT_EDITED to prevent replacement of the words
"edit"and"remark"into their aliases within the error messages.Illustration on escape character used:
"ran\u200edom"will display as"random"in the app"ran\u200edom".equals("random")will evaluate to false