Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage bug #117

Merged

Conversation

qlchan24
Copy link

The quantity field was not assigned to the updated quantity in the previous jsonAdaptedProduct causing the quantities of product not to be updated through update command

@codecov-io
Copy link

Codecov Report

Merging #117 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #117      +/-   ##
============================================
+ Coverage     69.99%   70.01%   +0.01%     
  Complexity      551      551              
============================================
  Files            89       89              
  Lines          1853     1854       +1     
  Branches        217      217              
============================================
+ Hits           1297     1298       +1     
  Misses          508      508              
  Partials         48       48              
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/clinic/storage/JsonAdaptedProduct.java 85.18% <100.00%> (+0.56%) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4162055...b873e62. Read the comment docs.

Copy link

@jeffreytjs jeffreytjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffreytjs jeffreytjs merged commit 8472c94 into AY2021S1-CS2103-W14-4:master Oct 12, 2020
@jeffreytjs jeffreytjs added this to the v1.2 milestone Oct 12, 2020
jeffreytjs added a commit to jeffreytjs/CLI-nic that referenced this pull request Oct 27, 2020
jeffreytjs added a commit to jeffreytjs/CLI-nic that referenced this pull request Oct 27, 2020
jeffreytjs added a commit to jeffreytjs/CLI-nic that referenced this pull request Oct 27, 2020
jeffreytjs added a commit to jeffreytjs/CLI-nic that referenced this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants