Write additional test cases to increase code coverage #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Criss-Wang
commented
Nov 4, 2020
•
Criss-Wang
commented
- Go through an overhaul of all code and write additional test cases for the code.
- Reduce code duplication (in particular the use of ModelStub) in test cases.
- Safe delete the AddProduct-related classes and occurances.
The bugs with undo/redo are fixed. Let's write addtional test cases to identify these bugs and also cover other components in the code.
# Conflicts: # src/test/java/seedu/clinic/logic/commands/UpdateCommandTest.java # src/test/java/seedu/clinic/logic/parser/ClinicParserTest.java
# Conflicts: # src/main/java/seedu/clinic/model/ModelManager.java # src/test/java/seedu/clinic/logic/commands/AddCommandTest.java # src/test/java/seedu/clinic/logic/commands/UpdateCommandTest.java # src/test/java/seedu/clinic/testutil/ModelStub.java
# Conflicts: # src/main/java/seedu/clinic/logic/commands/UndoCommand.java # src/test/java/seedu/clinic/logic/parser/EditCommandParserTest.java
Remove some redundant variables and methods and test more on the code.
jeffreytjs
reviewed
Nov 5, 2020
src/test/java/seedu/clinic/model/macro/UniqueMacroListTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
============================================
+ Coverage 70.94% 75.33% +4.39%
- Complexity 760 917 +157
============================================
Files 107 115 +8
Lines 2595 2956 +361
Branches 345 388 +43
============================================
+ Hits 1841 2227 +386
+ Misses 628 598 -30
- Partials 126 131 +5
Continue to review full report at Codecov.
|
zhengweii
reviewed
Nov 6, 2020
| } | ||
|
|
||
| @Test | ||
| public void execute_duplicateSupplier_throwsCommandException() { |
zhengweii
reviewed
Nov 7, 2020
Comment on lines
+267
to
+277
| public void parseAlias_validValueWithoutWhitespace_returnsEmail() throws Exception { | ||
| Alias expectedAlias = new Alias(VALID_ALIAS); | ||
| assertEquals(expectedAlias, ParserUtil.parseAlias(VALID_ALIAS)); | ||
| } | ||
|
|
||
| @Test | ||
| public void parseAlias_validValueWithWhitespace_returnsTrimmedEmail() throws Exception { | ||
| String aliasWithWhitespace = WHITESPACE + VALID_ALIAS + WHITESPACE; | ||
| Alias expectedAlias = new Alias(VALID_ALIAS); | ||
| assertEquals(expectedAlias, ParserUtil.parseAlias(aliasWithWhitespace)); | ||
| } |
There was a problem hiding this comment.
Oops a little confused here as well! Why is this returning an email??
zhengweii
reviewed
Nov 7, 2020
Comment on lines
+290
to
+296
| public void parseCommandString_validValueWithoutWhitespace_returnsEmail() throws Exception { | ||
| SavedCommandString expectedCommandString = new SavedCommandString(VALID_COMMAND_STRING); | ||
| assertEquals(expectedCommandString, ParserUtil.parseCommandString(VALID_COMMAND_STRING)); | ||
| } | ||
|
|
||
| @Test | ||
| public void parseCommandString_validValueWithWhitespace_returnsTrimmedEmail() throws Exception { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.