Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for JsonAdaptedConsultation #182

Merged
merged 4 commits into from
Nov 8, 2020

Conversation

chrisgzf
Copy link

@chrisgzf chrisgzf commented Nov 8, 2020

This PR's base is Rishi's PR #172, somehow GitHub won't let me set his fork as base.

EDIT: Oh LMAO I realised why... I think for me to be able to set his fork as the base, I need to PR to his fork instead... #forkingworkflowsucks Nvm, let's wait for #172 to be merged, then this PR will sync up with master correctly. (Until that happens, don't review yet, cos the diff will be harder to read)

This PR adds tests for JsonAdaptedConsultation.

Closes #176, #175

@chrisgzf chrisgzf added type.Task Something that needs to be done, but not a story, bug, or an epic. priority.Medium Nice to have labels Nov 8, 2020
@chrisgzf chrisgzf added this to the v1.4 milestone Nov 8, 2020
@chrisgzf chrisgzf self-assigned this Nov 8, 2020
@codecov-io
Copy link

codecov-io commented Nov 8, 2020

Codecov Report

Merging #182 (37685c4) into master (7347818) will increase coverage by 2.38%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #182      +/-   ##
============================================
+ Coverage     69.87%   72.25%   +2.38%     
- Complexity      588      612      +24     
============================================
  Files           100      100              
  Lines          1932     1932              
  Branches        223      223              
============================================
+ Hits           1350     1396      +46     
+ Misses          484      443      -41     
+ Partials         98       93       -5     
Impacted Files Coverage Δ Complexity Δ
...ava/seedu/address/model/attendance/Attendance.java 73.91% <0.00%> (+13.04%) 9.00% <0.00%> (+2.00%)
src/main/java/seedu/address/model/UserPrefs.java 90.62% <0.00%> (+15.62%) 14.00% <0.00%> (+3.00%)
src/main/java/seedu/address/model/tag/Tag.java 100.00% <0.00%> (+20.00%) 8.00% <0.00%> (+3.00%)
...rc/main/java/seedu/address/logic/LogicManager.java 95.23% <0.00%> (+23.80%) 7.00% <0.00%> (+4.00%)
...seedu/address/storage/JsonAdaptedConsultation.java 95.00% <0.00%> (+77.50%) 12.00% <0.00%> (+10.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7347818...37685c4. Read the comment docs.

@chrisgzf chrisgzf linked an issue Nov 8, 2020 that may be closed by this pull request
Copy link

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chrisgzf chrisgzf merged commit 1c24554 into AY2021S1-CS2103T-F11-1:master Nov 8, 2020
@chrisgzf chrisgzf deleted the json-consult-tests branch November 8, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for JsonAdaptedConsultation Add Consultation Test at Storage
4 participants