forked from nus-cs2103-AY2021S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read student data #47
Merged
kwannoel
merged 5 commits into
AY2021S1-CS2103T-F11-1:master
from
Rishi5154:read-student-data
Oct 6, 2020
Merged
Read student data #47
kwannoel
merged 5 commits into
AY2021S1-CS2103T-F11-1:master
from
Rishi5154:read-student-data
Oct 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rishi5154
added
type.Enhancement
An enhancement to an existing story
priority.High
Must do
labels
Oct 5, 2020
kwannoel
reviewed
Oct 6, 2020
sun-yitao
reviewed
Oct 6, 2020
kwannoel
reviewed
Oct 6, 2020
kwannoel
requested changes
Oct 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor naming change. Otherwise LGTM. Thanks for ensuring it compiles 👍
Rishi5154
force-pushed
the
read-student-data
branch
from
October 6, 2020 01:49
7162070
to
ea20222
Compare
kwannoel
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
See commit log for details.
List & Find working as intended
Edit portion has been partially completed in order to compile and run program for testing
JUnit tests written
Closes #13