Add Meeting Test Cases #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update files
Combined from and to test cases because they are similar Omit TitleDescrpitionContainsKeyword test cases because it is similar to NameDescrptionContainsKeyword test case.
This was
linked to
issues
Oct 27, 2020
Closed
claraadora
suggested changes
Oct 28, 2020
| @@ -52,12 +52,12 @@ | |||
| public static final String LOCATION_DESC_A = " " + PREFIX_LOCATION + VALID_LOCATION_A; | |||
| public static final String LOCATION_DESC_B = " " + PREFIX_LOCATION + VALID_LOCATION_B; | |||
|
|
|||
| public static final String INVALID_TITLE_DESC = " " + PREFIX_TITLE + "Meeting&"; // '&' not allowed in names | |||
| public static final String INVALID_TITLE_DESC = " " + PREFIX_TITLE + ""; // '&' not allowed in names | |||
There was a problem hiding this comment.
I think the comment here is outdated
| public static final String INVALID_FROM_DESC = " " + PREFIX_FROM + "3-03-2020 09:30"; // missing '0' digit | ||
| public static final String INVALID_TO_DESC = " " + PREFIX_TO + "03-03-2020 0930"; // missing colon | ||
| public static final String INVALID_CONTACTS_DESC = " " + PREFIX_CONTACTS + "1 2 3"; // no commas | ||
| public static final String INVALID_LOCATION_DESC = " " + PREFIX_LOCATION + ""; // 'friend' not allowed in roles |
| assertThrows(NullPointerException.class, () -> new Location((String) null)); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Is this supposed to be constructor_invalidLocation?
Comment on lines
26
to
40
| @Test | ||
| public void contains_nullPerson_throwsNullPointerException() { | ||
| assertThrows(NullPointerException.class, () -> uniqueMeetingList.contains(null)); | ||
| } | ||
|
|
||
| @Test | ||
| public void contains_personNotInList_returnsFalse() { | ||
| assertFalse(uniqueMeetingList.contains(MEETING_A)); | ||
| } | ||
|
|
||
| @Test | ||
| public void contains_personInList_returnsTrue() { | ||
| uniqueMeetingList.add(MEETING_A); | ||
| assertTrue(uniqueMeetingList.contains(MEETING_A)); | ||
| } |
There was a problem hiding this comment.
I think we can change the method names to meeting here?
Comment on lines
+42
to
+49
| // @Test | ||
| // public void contains_MeetingWithSameIdentityFieldsInList_returnsTrue() { | ||
| // uniqueMeetingList.add(MEETING_A); | ||
| // Meeting editedMeetingA = new MeetingBuilder(MEETING_A).withDescription(VALID_DESCRIPTION_B) | ||
| // .build(); | ||
| // assertTrue(uniqueMeetingList.contains(editedMeetingA)); | ||
| // } | ||
|
|
There was a problem hiding this comment.
Should we delete this comment or add a TODO comment?
claraadora
approved these changes
Oct 28, 2020
Productiv
automation
moved this from PRs Pending Approvals
to PRs approved / Ready for Testing
Oct 28, 2020
Productiv
automation
moved this from PRs approved / Ready for Testing
to Issues Done / PRs Merged (After Testing)
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Add Command and Model Meeting test cases.