-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend deadline to use DateTime util class; Create test cases for Deliverables #112
Amend deadline to use DateTime util class; Create test cases for Deliverables #112
Conversation
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
============================================
+ Coverage 47.39% 54.14% +6.75%
- Complexity 606 679 +73
============================================
Files 153 154 +1
Lines 2817 2809 -8
Branches 324 322 -2
============================================
+ Hits 1335 1521 +186
+ Misses 1380 1169 -211
- Partials 102 119 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor comments.
-Now to get string of Deadline, we use getDeadline().toString() and not getDeadline().value anymore. Fixes #86
-A truckload of test cases, for now. #62