Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend deadline to use DateTime util class; Create test cases for Deliverables #112

Merged

Conversation

gabztcr
Copy link

@gabztcr gabztcr commented Oct 27, 2020

-Now to get string of Deadline, we use getDeadline().toString() and not getDeadline().value anymore. Fixes #86
-A truckload of test cases, for now. #62

@gabztcr gabztcr added this to the v1.3 milestone Oct 27, 2020
@gabztcr gabztcr added this to PRs Pending Approvals in Productiv via automation Oct 27, 2020
@shadowezz shadowezz linked an issue Oct 28, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #112 into master will increase coverage by 6.75%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #112      +/-   ##
============================================
+ Coverage     47.39%   54.14%   +6.75%     
- Complexity      606      679      +73     
============================================
  Files           153      154       +1     
  Lines          2817     2809       -8     
  Branches        324      322       -2     
============================================
+ Hits           1335     1521     +186     
+ Misses         1380     1169     -211     
- Partials        102      119      +17     
Impacted Files Coverage Δ Complexity Δ
...address/logic/commands/deliverable/AddCommand.java 100.00% <ø> (+100.00%) 8.00 <0.00> (+8.00)
...ress/logic/commands/deliverable/DeleteCommand.java 100.00% <ø> (+100.00%) 7.00 <0.00> (+7.00)
.../address/logic/commands/meeting/DeleteCommand.java 100.00% <ø> (ø) 7.00 <0.00> (ø)
...du/address/logic/commands/meeting/EditCommand.java 82.27% <ø> (ø) 12.00 <0.00> (ø)
...ess/logic/parser/deliverable/AddCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...edu/address/model/deliverable/DeliverableBook.java 87.50% <ø> (+87.50%) 11.00 <0.00> (+11.00)
...java/seedu/address/model/meeting/meeting/From.java 60.00% <ø> (ø) 4.00 <0.00> (ø)
...ss/storage/deliverable/JsonAdaptedDeliverable.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/ui/DeliverableCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/seedu/address/ui/DeliverableDetailsPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6227a24...2c8425e. Read the comment docs.

Productiv automation moved this from PRs Pending Approvals to PRs approved / Ready for Testing Oct 28, 2020
Copy link

@shadowezz shadowezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments.

@gabztcr gabztcr merged commit 7480287 into AY2021S1-CS2103T-F11-2:master Oct 28, 2020
Productiv automation moved this from PRs approved / Ready for Testing to Issues Done / PRs Merged (After Testing) Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Productiv
Issues Done / PRs Merged (After Testing)
Development

Successfully merging this pull request may close these issues.

Amend by/DEADLINE field for Deliverable Add testing for deliverable fields, commands and parsing
3 participants