Updates to ui #188

chrystalquek · 2020-11-02T18:08:32Z

Fix #144 (addressbook.log -> productiv.log)
Fix #139 (addressbook -> contactbook, commandresults 'book' -> 'list')
Fix #169
Fix #132 (warning message when switching to same mode)
Fix #164 (shorten Switch commands)

codecov-io · 2020-11-03T01:34:24Z

Codecov Report

Merging #188 into master will increase coverage by 0.10%.
The diff coverage is 84.61%.

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
+ Coverage     52.99%   53.09%   +0.10%     
- Complexity      742      744       +2     
============================================
  Files           166      166              
  Lines          3106     3113       +7     
  Branches        344      345       +1     
============================================
+ Hits           1646     1653       +7     
  Misses         1353     1353              
  Partials        107      107

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/seedu/address/MainApp.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...in/java/seedu/address/commons/core/LogsCenter.java	`78.37% <ø> (ø)`	`10.00 <0.00> (ø)`
...main/java/seedu/address/commons/core/Messages.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...dress/logic/commands/deliverable/ClearCommand.java	`100.00% <ø> (ø)`	`2.00 <0.00> (ø)`
...ress/logic/commands/deliverable/DeleteCommand.java	`100.00% <ø> (ø)`	`7.00 <0.00> (ø)`
...ddress/logic/commands/deliverable/DoneCommand.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...ddress/logic/commands/deliverable/EditCommand.java	`94.66% <ø> (ø)`	`12.00 <0.00> (ø)`
...ddress/logic/commands/deliverable/FindCommand.java	`100.00% <ø> (ø)`	`6.00 <0.00> (ø)`
...ddress/logic/commands/deliverable/ViewCommand.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...u/address/logic/commands/meeting/ClearCommand.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff3b39...0226346. Read the comment docs.

gabztcr

Added comments for your review 😎
Thanks for the great effort here 👍

gabztcr · 2020-11-03T13:44:10Z

docs/DeveloperGuide.md

@@ -801,15 +801,15 @@ testers are expected to do more *exploratory* testing.

 1. Data files are saved in a `data` folder.<br>
 3 JSON files are created:
-    * `addressbook.json`
+    * `contactbook.json`
    * `meetingBook.json`


Lower case 'b'

gabztcr · 2020-11-03T13:50:58Z

docs/UserGuide.md


 Format: `switch MODE`
-* `switch`  `deliverable`, `meeting` and `contact` mode will display your list of deliverables, meetings and contacts in the left panel respectively, 
-e.g. `switch contact` will display your list of contacts.
+* `MODE` can be dashboard (`db`), deliverable (`dv`), meeting (`m`) or contact (`c`).


Reversed information: should be "MODE can be db (dashboard), dv (deliverable), ..."

gabztcr · 2020-11-03T13:52:24Z

docs/UserGuide.md

-* `switch`  `deliverable`, `meeting` and `contact` mode will display your list of deliverables, meetings and contacts in the left panel respectively, 
-e.g. `switch contact` will display your list of contacts.
+* `MODE` can be dashboard (`db`), deliverable (`dv`), meeting (`m`) or contact (`c`).
+* `switch` `dv`, `m` or `c` mode will display your list of deliverables, meetings and contacts in the left panel respectively, 


Just a mental note that we may need to explain the main components in our GUI (command box, feedback box, navbar, left panel, right panel) at the start of the UG with a screenshot

gabztcr · 2020-11-03T14:03:48Z

src/main/java/seedu/address/logic/commands/deliverable/ViewCommand.java

@@ -18,7 +18,8 @@
    public static final String COMMAND_WORD = "view";
    public static final String MESSAGE_VIEW_DELIVERABLE_SUCCESS = "Viewing deliverable: %1$s";
    public static final String MESSAGE_USAGE = COMMAND_WORD
-            + ": Views the details of the deliverable identified by the index number used in the deliverable list.\n"
+            + ": Views the details of the deliverable identified by the index number used in "


May want to consider replacing "used" with "as shown"/"as seen"?

Original phrasing of AB3, thinking it would better to just stick to that

gabztcr · 2020-11-03T14:04:38Z

src/main/java/seedu/address/logic/commands/meeting/AddCommand.java

@@ -33,7 +33,7 @@
            + PREFIX_LOCATION + "Room 1A";

    public static final String MESSAGE_SUCCESS = "New meeting added: %1$s";
-    public static final String MESSAGE_DUPLICATE_MEETING = "This meeting already exists in the meeting book";
+    public static final String MESSAGE_DUPLICATE_MEETING = "This meeting already exists in the meeting list";


Missing fullstop?

gabztcr · 2020-11-03T14:12:15Z

src/main/java/seedu/address/logic/commands/mode/SwitchCommand.java


    public static final String MESSAGE_SUCCESS = "Mode switched to: %1$s";
+    public static final String MESSAGE_SAME_MODE = "Switched to same mode: %s!";


Consider using You are already in this mode! or Mode is presently displayed! so it appears more like the user made a mistake.

gabztcr · 2020-11-03T14:13:03Z

src/main/java/seedu/address/logic/commands/mode/SwitchCommand.java

+            + "Parameters: MODE (must be " + ModeEnum.getModeOptions()
+            + ")\n"
+            + "Example: " + COMMAND_WORD + " " + ModeEnum.DELIVERABLE.getArgument();
+

    public static final String MESSAGE_SUCCESS = "Mode switched to: %1$s";


Does this mean users will get something like Mode switched to: dv? Are we able to convert into Mode switch to: deliverable (along with the other models) instead? 😨

Yes, its currently Mode switched to: Deliverable

gabztcr · 2020-11-03T14:15:28Z

src/main/java/seedu/address/logic/commands/person/AddCommand.java

@@ -34,7 +34,7 @@
            + PREFIX_DESCRIPTION + "End user";

    public static final String MESSAGE_SUCCESS = "New contact added: %1$s";
-    public static final String MESSAGE_DUPLICATE_PERSON = "This contact already exists in the address book";
+    public static final String MESSAGE_DUPLICATE_PERSON = "This contact already exists in the contact list";


Missing exclamation mark? (Just ensure the message punctuations are consistent throughout the models)

gabztcr · 2020-11-03T14:19:47Z

src/main/java/seedu/address/logic/commands/person/ViewCommand.java

@@ -16,9 +16,9 @@
 */
 public class ViewCommand extends Command {
    public static final String COMMAND_WORD = "view";
-    public static final String MESSAGE_VIEW_CONTACT_SUCCESS = "Viewing contact: %1$s";
+    public static final String MESSAGE_VIEW_PERSON_SUCCESS = "Viewing contact: %1$s";


Think we agreed previously that the messages should be from the perspective of the app. Here and else models, Viewing contact should be Displayed contact: %1$s.

Also, I think list command should be Listed all contacts! if it is not already. Clear should be Cleared all contacts!.

To be fixed by #182

Updated in that PR

claraadora

LGTM

Updated according to comments.

chrystalquek added 5 commits November 2, 2020 22:25

Change addressbook.json to contactbook.json

3d35bf3

Update some feedback messages

4e54fa7

Move MESSAGE_MEETINGS_LISTED_OVERVIEW to Messages class

f76c007

Update SwitchCommand message

b08797e

Fix order of imports

1ed909c

chrystalquek added this to the mid-v1.4 milestone Nov 2, 2020

chrystalquek requested a review from MerlinLim November 2, 2020 18:08

chrystalquek self-assigned this Nov 2, 2020

chrystalquek added this to PRs Pending Approvals in Productiv via automation Nov 2, 2020

chrystalquek added 5 commits November 3, 2020 02:29

Shorten switch commands

970c590

Fix View Command message for Person

bc20f2c

Throw exception when switch to same mode

38ed718

Shorten switch commands

71ee641

rename to MESSAGE_SAME_MODE

b4f3ec6

gabztcr previously requested changes Nov 3, 2020

View reviewed changes

chrystalquek added 4 commits November 3, 2020 23:33

Minor edits to UG

2363c49

Minor edits to documentation

e094f8d

Merge branch 'master' into renaming-address-to-contact

8a18ab7

Fix import

0226346

claraadora approved these changes Nov 3, 2020

View reviewed changes

Productiv automation moved this from PRs Pending Approvals to PRs approved / Ready for Testing Nov 3, 2020

chrystalquek merged commit 3d5a9e7 into AY2021S1-CS2103T-F11-2:master Nov 3, 2020

Productiv automation moved this from PRs approved / Ready for Testing to Issues Done / PRs Merged (After Testing) Nov 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to ui #188

Updates to ui #188

chrystalquek commented Nov 2, 2020

codecov-io commented Nov 3, 2020 •

edited

gabztcr left a comment

gabztcr Nov 3, 2020

gabztcr Nov 3, 2020

gabztcr Nov 3, 2020

gabztcr Nov 3, 2020

chrystalquek Nov 3, 2020

gabztcr Nov 3, 2020

gabztcr Nov 3, 2020

gabztcr Nov 3, 2020

chrystalquek Nov 3, 2020

gabztcr Nov 3, 2020

gabztcr Nov 3, 2020

chrystalquek Nov 3, 2020 •

edited

claraadora left a comment


		public static final String MESSAGE_SUCCESS = "Mode switched to: %1$s";
		public static final String MESSAGE_SAME_MODE = "Switched to same mode: %s!";

Updates to ui #188

Updates to ui #188

Conversation

chrystalquek commented Nov 2, 2020

codecov-io commented Nov 3, 2020 • edited

Codecov Report

gabztcr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrystalquek Nov 3, 2020 • edited

Choose a reason for hiding this comment

claraadora left a comment

Choose a reason for hiding this comment

codecov-io commented Nov 3, 2020 •

edited

chrystalquek Nov 3, 2020 •

edited