-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UG #195
Update UG #195
Conversation
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
============================================
+ Coverage 53.13% 53.85% +0.71%
- Complexity 744 751 +7
============================================
Files 166 166
Lines 3122 3123 +1
Branches 349 347 -2
============================================
+ Hits 1659 1682 +23
+ Misses 1353 1333 -20
+ Partials 110 108 -2 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments 😎
docs/UserGuide.md
Outdated
|
||
<div markdown="block" class="alert alert-info"> | ||
|
||
**:information_source: Note:** You cannot add a contact with the same name and email as another contact in your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to edit to Chrystal's phrasing: You cannot add a contact with the same name and email as another existing contact
. Here and elsewhere for the other commands/models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to leave out the example to keep the Note
short. What do you think?
@@ -202,13 +216,27 @@ Format: `add t/TITLE m/MILESTONE by/DEADLINE [d/DESCRIPTION] [c/CONTACTS]` | |||
* `MILESTONE` is the milestone tagged to the deliverable. | |||
* `MILESTONE` takes in numerical values separated by periods, e.g. `1.3`, `14.2.1`. | |||
* `DEADLINE` is the due date time of the deliverable in DD-MM-YYYY HH:mm format. | |||
* `DEADLINE` can be in the past but must not be earlier than the year 2019. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we edit the code to validate this when we parse the datetime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I did in the other PR
docs/UserGuide.md
Outdated
|
||
* You cannot add a deliverable with the same title as another deliverable in your deliverable list.<br> | ||
e.g. `add t/Build Login page m/1.0 by/10-11-2020 18:00` will not work if there is another deliverable with the title | ||
`Build Login page` in your deliverable list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to consider leaving out examples as mentioned previously.
docs/UserGuide.md
Outdated
* `add r/stk n/Betsy Crowe e/betsybet872@pmail.com` | ||
adds a stakeholder with the name `Betsy Crowe` and email `betsybet872@pmail.com`. | ||
|
||
<div markdown="span" class="alert alert-primary">:bulb: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think tip should be right after Note, not Examples
https://ay2021s1-cs2103t-f11-2.github.io/tp/UserGuide.html#adding-a-meeting-add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.