Clean up error messages in Productiv #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinLim
reviewed
Nov 6, 2020
| * `DESCRIPTION` contains additional details about the meeting, e.g. agenda. | ||
| * `CONTACTS` represents the contacts involved in the meeting. | ||
| * `CONTACTS` is a comma-separated string of names. | ||
| * `CONTACTS` represents the contact(s) involved in the meeting. |
There was a problem hiding this comment.
Include optional plural for contacts in line 272
There was a problem hiding this comment.
Reworded to "As CONTACTS is not related to your contact list, you can include those not present in it."
| @@ -13,6 +13,7 @@ | |||
| public class Description { | |||
|
|
|||
| public static final String EMPTY_DESCRIPTION_FIELD = "-"; | |||
| // TODO: remove after allowing blank optional fields to pass. | |||
| public static final String MESSAGE_CONSTRAINTS = "Descriptions can take any values, and it should not be blank"; | |||
There was a problem hiding this comment.
Message will be removed later on, so will not be making extra changes.
| @@ -11,6 +11,7 @@ | |||
| */ | |||
| public class Location { | |||
| public static final String EMPTY_LOCATION_FIELD = "-"; | |||
| // TODO: remove after allowing blank optional fields to pass. | |||
| public static final String MESSAGE_CONSTRAINTS = "Locations can take any values, and it should not be blank"; | |||
There was a problem hiding this comment.
Message will be removed later on, so will not be making extra changes.
MerlinLim
approved these changes
Nov 6, 2020
Productiv
automation
moved this from PRs Pending Approvals
to PRs approved / Ready for Testing
Nov 6, 2020
Productiv
automation
moved this from PRs approved / Ready for Testing
to Issues Done / PRs Merged (After Testing)
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #224
-Did not remove error message for "Description" and "Location" fields yet. Waiting for Wenjie to amend code first to allow blank fields to pass for optional fields, before deleting these two fields' error messages (they will then accept everything including blanks)