Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User guide update #231

Merged
merged 11 commits into from
Nov 6, 2020
Merged

User guide update #231

merged 11 commits into from
Nov 6, 2020

Conversation

MerlinLim
Copy link

  • Restructure order of commands (shift View Command)
  • Ensure e.g add commands work
  • Fix grammar and Styling
  • Fix date time format

@MerlinLim MerlinLim added this to the v1.4 milestone Nov 6, 2020
@MerlinLim MerlinLim self-assigned this Nov 6, 2020
@MerlinLim MerlinLim added this to PRs Pending Approvals in Productiv via automation Nov 6, 2020

* **`delete`**`1` : If in meeting mode, deletes the 1st meeting shown.
1. **`delete`** `1` : Deletes the 1st deliverable shown.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just in case, maybe better to leave the "if in .. mode"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like its alright, actually if i wanted to really include I should be including that condition for "add t/deliverable..." instead

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, ok just saw the 'sequence'

e.g. in `add n/NAME`, `NAME` is a parameter for the name field `n`, which can be used as `add n/Jason`.
e.g. in `add n/NAME`, `NAME` is a parameter for the name field `n`, which can be used as `add n/Jason`.<br>
:bulb: **Tip:** If you are not sure what specific parameter to supply for any of the required fields, supply an estimate or random value as place holder.<br>
:bulb: **Tip:** For any fields with an unspecified maximum length, the display may look untidy if you supply a long parameter.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more like a note.
maybe can say that the list view will be truncated for fields with long parameters

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will ammend

* `INDEX` must be a positive integer.

Example:
* `view 2` views the 2nd deliverable in your displayed deliverable list.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this is a bit weird, should it be displays or some other word

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it is abit weird but im not sure what else to leave it as. Its not wrong tho

* `CONTACTS` is a comma-separated string of names.
* `LOCATION` is the location of the meeting.

<div markdown="block" class="alert alert-info">

**:information_source: Notes:**<br>

* Meeting timings may overlap as you may wish to send a representative for your clashing meetings.
* Different meeting may have overlapping timings as you may wish to send a representative for your clashing meetings.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meetings

adds a meeting with the title `User research review`, start date time `15-12-2020 13:00`,
end date time `15-12-2020 15:00`, and location `Meeting room A`.
end date time `15:00`, and location `Meeting room A`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end time

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comma

Long parameters will be truncated
Copy link

@chrystalquek chrystalquek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Productiv automation moved this from PRs Pending Approvals to PRs approved / Ready for Testing Nov 6, 2020
@MerlinLim MerlinLim merged commit 1f48845 into AY2021S1-CS2103T-F11-2:master Nov 6, 2020
Productiv automation moved this from PRs approved / Ready for Testing to Issues Done / PRs Merged (After Testing) Nov 6, 2020
@MerlinLim MerlinLim linked an issue Nov 6, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Productiv
Issues Done / PRs Merged (After Testing)
Development

Successfully merging this pull request may close these issues.

UG: Tip for compulsory fields
2 participants