Add structure (Logic, Model, Storage) for meeting component #34
Conversation
| */ | ||
| public Command parseCommand(String userInput) throws ParseException { | ||
|
|
||
| final String commandWord = userInput.split(" ")[0]; |
There was a problem hiding this comment.
Possible to follow Pattern BASIC_COMMAND_FORMAT check used in AddressBookParser?
Reason why ModeParser did not use Pattern is because the commands that ModeParser will parse does not follow the regular format of commands with all the Prefixes.
| * API of the Storage component | ||
| */ | ||
| // TODO: build and change to MeetingBookStorage | ||
| public interface StorageMeeting extends AddressBookStorage, UserPrefsStorage { |
There was a problem hiding this comment.
Might need to take out UserPrefsStorage from Person Package.
AddressBookStorage seems to specific to the Person Model, what do you think?
| */ | ||
| CommandResult execute(String commandText) throws CommandException, ParseException; | ||
|
|
||
| boolean isMeetingCommand(String commandText); |
There was a problem hiding this comment.
Can remove all isMeetingCommand methods
Implemented only for LogicMode because need to know whether to switch mode in MainWindow, whereas it is certain that LogicMeeting will be handling a user input if the current mode is Meeting
| * @return feedback message of the operation result for display | ||
| * @throws CommandException If an error occurs during command execution. | ||
| */ | ||
| public abstract CommandResult execute(ModelMeeting modelMeeting) throws CommandException; |
There was a problem hiding this comment.
Will need to accept Contacts Model eventually also so that index of contact can be referenced
| */ | ||
| public Command parseCommand(String userInput) throws ParseException { | ||
|
|
||
| final String commandWord = userInput.split(" ")[0]; |
There was a problem hiding this comment.
For cleaner implementation, possible to use Pattern found in AddressBookParser?
split method used in ModeParser because none of the mode commands use prefixes.
|
|
||
| private final MeetingBook meetingBook; | ||
|
|
||
| // TODO: May need to add userPrefs |
There was a problem hiding this comment.
May be good to just add userPrefs (just reference to same object)
There was a problem hiding this comment.
Eventually will have a FilteredList filteredMeetings ?
| * API of the Storage component | ||
| */ | ||
| // TODO: build and change to MeetingBookStorage | ||
| public interface StorageMeeting extends AddressBookStorage, UserPrefsStorage { |
There was a problem hiding this comment.
Good to take out UserPrefsStorage from person package
Will StorageMeeting be extending from AddressBookStorage?
No description provided.