Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add milestone attribute for deliverable. #72

Merged
merged 9 commits into from
Oct 18, 2020

Conversation

shadowezz
Copy link

  • Implemented UI for milestone as a tag

@shadowezz shadowezz added this to the mid-v1.3 milestone Oct 15, 2020
@shadowezz shadowezz added this to PRs Pending Approvals in Productiv via automation Oct 15, 2020
@@ -316,11 +316,3 @@
-fx-background-radius: 2;
-fx-font-size: 11;
}

.tag_label {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is person card currently using this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait i dont think so right

@codecov-io
Copy link

Codecov Report

Merging #72 into master will increase coverage by 0.25%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #72      +/-   ##
============================================
+ Coverage     47.17%   47.42%   +0.25%     
- Complexity      540      560      +20     
============================================
  Files           137      139       +2     
  Lines          2474     2545      +71     
  Branches        277      286       +9     
============================================
+ Hits           1167     1207      +40     
- Misses         1245     1274      +29     
- Partials         62       64       +2     
Impacted Files Coverage Δ Complexity Δ
...address/logic/commands/deliverable/AddCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ddress/logic/commands/deliverable/DoneCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ess/logic/parser/deliverable/AddCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...du/address/logic/parser/deliverable/CliSyntax.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...u/address/logic/parser/deliverable/ParserUtil.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ss/storage/deliverable/JsonAdaptedDeliverable.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/ui/DeliverableCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ess/model/deliverable/deliverable/Deliverable.java 45.09% <25.00%> (-1.57%) 14.00 <1.00> (+1.00) ⬇️
...dress/model/deliverable/deliverable/Milestone.java 60.00% <60.00%> (ø) 3.00 <3.00> (?)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0db7dd2...5d7f1b5. Read the comment docs.

Productiv automation moved this from PRs Pending Approvals to PRs approved / Ready for Testing Oct 18, 2020
@shadowezz shadowezz merged commit e14561c into AY2021S1-CS2103T-F11-2:master Oct 18, 2020
Productiv automation moved this from PRs approved / Ready for Testing to Issues Done / PRs Merged (After Testing) Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Productiv
Issues Done / PRs Merged (After Testing)
Development

Successfully merging this pull request may close these issues.

As a product manager, I can package deliverables into different milestones
3 participants