Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Meeting Edit Command #75

Merged
merged 4 commits into from
Oct 18, 2020
Merged

Add Meeting Edit Command #75

merged 4 commits into from
Oct 18, 2020

Conversation

MerlinLim
Copy link

No description provided.

Edit Command edits specified meeting based on user input.
@MerlinLim MerlinLim added this to the mid-v1.3 milestone Oct 18, 2020
@MerlinLim MerlinLim added this to PRs Pending Approvals in Productiv via automation Oct 18, 2020
@MerlinLim MerlinLim self-assigned this Oct 18, 2020
@codecov-io
Copy link

codecov-io commented Oct 18, 2020

Codecov Report

Merging #75 into master will increase coverage by 4.23%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #75      +/-   ##
============================================
+ Coverage     47.71%   51.94%   +4.23%     
- Complexity      556      601      +45     
============================================
  Files           138      138              
  Lines          2513     2541      +28     
  Branches        281      288       +7     
============================================
+ Hits           1199     1320     +121     
+ Misses         1252     1125     -127     
- Partials         62       96      +34     
Impacted Files Coverage Δ Complexity Δ
...ddress/logic/parser/meeting/MeetingBookParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ddress/logic/parser/meeting/EditCommandParser.java 88.88% <82.35%> (+88.88%) 8.00 <0.00> (+8.00)
...du/address/logic/commands/meeting/EditCommand.java 85.33% <100.00%> (+85.33%) 12.00 <0.00> (+12.00)
...c/main/java/seedu/address/model/util/Contacts.java 46.66% <0.00%> (ø) 5.00% <0.00%> (+2.00%)
.../seedu/address/model/meeting/meeting/Location.java 46.66% <0.00%> (ø) 5.00% <0.00%> (+2.00%)
...edu/address/logic/commands/meeting/AddCommand.java 100.00% <0.00%> (ø) 8.00% <0.00%> (ø%)
...a/seedu/address/model/meeting/meeting/Meeting.java 74.00% <0.00%> (+6.00%) 15.00% <0.00%> (+3.00%)
...dress/model/meeting/meeting/UniqueMeetingList.java 53.65% <0.00%> (+9.75%) 12.00% <0.00%> (+2.00%)
...edu/address/model/meeting/ModelMeetingManager.java 44.68% <0.00%> (+10.63%) 9.00% <0.00%> (+2.00%)
.../seedu/address/logic/parser/util/ParserCommon.java 61.53% <0.00%> (+15.38%) 4.00% <0.00%> (+1.00%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb5e84...f8cb5a0. Read the comment docs.

Copy link

@shadowezz shadowezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor typos.

@@ -32,7 +29,19 @@
public class EditCommand extends Command {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have some typos in the this class. Should be "meeting" instead of "person".

Productiv automation moved this from PRs Pending Approvals to PRs approved / Ready for Testing Oct 18, 2020
Copy link

@shadowezz shadowezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MerlinLim MerlinLim merged commit 0e05660 into AY2021S1-CS2103T-F11-2:master Oct 18, 2020
Productiv automation moved this from PRs approved / Ready for Testing to Issues Done / PRs Merged (After Testing) Oct 18, 2020
@MerlinLim MerlinLim removed the request for review from gabztcr October 18, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Productiv
Issues Done / PRs Merged (After Testing)
Development

Successfully merging this pull request may close these issues.

As a product manager who values flexibility, I can edit existing meetings
3 participants