Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Autosort for Meeting #77

Merged
merged 10 commits into from
Oct 18, 2020

Conversation

claraadora
Copy link

No description provided.

@claraadora claraadora added this to the mid-v1.3 milestone Oct 18, 2020
@codecov-io
Copy link

Codecov Report

Merging #77 into master will increase coverage by 4.43%.
The diff coverage is 92.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #77      +/-   ##
============================================
+ Coverage     47.71%   52.15%   +4.43%     
- Complexity      556      606      +50     
============================================
  Files           138      139       +1     
  Lines          2513     2558      +45     
  Branches        281      288       +7     
============================================
+ Hits           1199     1334     +135     
+ Misses         1252     1127     -125     
- Partials         62       97      +35     
Impacted Files Coverage Δ Complexity Δ
...dress/model/meeting/meeting/UniqueMeetingList.java 57.14% <75.00%> (+13.24%) 13.00 <1.00> (+3.00)
.../java/seedu/address/model/meeting/MeetingBook.java 88.88% <100.00%> (+22.22%) 12.00 <1.00> (+3.00)
...a/seedu/address/model/meeting/meeting/Meeting.java 72.54% <100.00%> (+4.54%) 15.00 <1.00> (+3.00)
.../address/model/meeting/util/MeetingComparator.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...c/main/java/seedu/address/model/util/DateTime.java 86.53% <100.00%> (+0.26%) 21.00 <1.00> (+1.00)
...c/main/java/seedu/address/model/util/Contacts.java 46.66% <0.00%> (ø) 5.00% <0.00%> (+2.00%)
.../seedu/address/model/meeting/meeting/Location.java 46.66% <0.00%> (ø) 5.00% <0.00%> (+2.00%)
...ddress/logic/parser/meeting/MeetingBookParser.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f622931...c423567. Read the comment docs.

Copy link

@MerlinLim MerlinLim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Edit Command as well, person cards auto sort as expected. Left a minor remark for clarification, LGTM.

@claraadora
Copy link
Author

Closes: #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SORT] As a product manager, I can view my meetings as a sorted whole
3 participants