Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unremind command to work with reminded assignment list #143

Merged

Conversation

ChooJiaXin
Copy link
Collaborator

closes #142

Deleted test cases involving unfiltered and filtered lists as the unfiltered and filtered list is only relevant for commands working with the main assignment list.

@ChooJiaXin ChooJiaXin added the enhancement New feature or request label Oct 23, 2020
@ChooJiaXin ChooJiaXin added this to the v1.3b milestone Oct 23, 2020
@ChooJiaXin ChooJiaXin self-assigned this Oct 23, 2020
@codecov-io
Copy link

Codecov Report

Merging #143 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #143   +/-   ##
=========================================
  Coverage     50.49%   50.49%           
+ Complexity      522      521    -1     
=========================================
  Files           108      108           
  Lines          2319     2317    -2     
  Branches        286      285    -1     
=========================================
- Hits           1171     1170    -1     
  Misses         1074     1074           
+ Partials         74       73    -1     
Impacted Files Coverage Δ Complexity Δ
.../seedu/address/logic/commands/UnremindCommand.java 86.95% <100.00%> (+2.95%) 9.00 <0.00> (-1.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f45fc...d0cc074. Read the comment docs.

Copy link

@andreatanky andreatanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChooJiaXin ChooJiaXin merged commit 4c4db2e into AY2021S1-CS2103T-F11-3:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unremind with reminded assignments list index
3 participants