-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto update list #144
Auto update list #144
Conversation
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
============================================
- Coverage 51.95% 51.90% -0.05%
- Complexity 559 561 +2
============================================
Files 113 114 +1
Lines 2458 2487 +29
Branches 301 302 +1
============================================
+ Hits 1277 1291 +14
- Misses 1099 1113 +14
- Partials 82 83 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I was at first worried about nested loops but figured there isn't a much better way anyways
I refactored the code so that the nesting isn't that bad and made the code neater :) |
closes #104
Will add test cases in v1.4/after @hyngkng is done changing all addresss book to ProductiveNus