Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto update list #144

Merged

Conversation

ChooJiaXin
Copy link
Collaborator

@ChooJiaXin ChooJiaXin commented Oct 23, 2020

closes #104

Will add test cases in v1.4/after @hyngkng is done changing all addresss book to ProductiveNus

@ChooJiaXin ChooJiaXin added bug Something isn't working help wanted Extra attention is needed labels Oct 23, 2020
@ChooJiaXin ChooJiaXin added this to the v1.3b milestone Oct 23, 2020
@ChooJiaXin ChooJiaXin self-assigned this Oct 23, 2020
@ChooJiaXin ChooJiaXin added enhancement New feature or request type.Task Our task to complete and removed bug Something isn't working help wanted Extra attention is needed labels Oct 27, 2020
@codecov-io
Copy link

Codecov Report

Merging #144 into master will decrease coverage by 0.04%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #144      +/-   ##
============================================
- Coverage     51.95%   51.90%   -0.05%     
- Complexity      559      561       +2     
============================================
  Files           113      114       +1     
  Lines          2458     2487      +29     
  Branches        301      302       +1     
============================================
+ Hits           1277     1291      +14     
- Misses         1099     1113      +14     
- Partials         82       83       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/model/AddressBook.java 69.14% <35.00%> (-9.52%) 23.00 <1.00> (+1.00) ⬇️
.../java/seedu/address/model/task/UniqueTaskList.java 35.29% <60.00%> (ø) 7.00 <3.00> (ø)
...eedu/address/logic/parser/DeleteCommandParser.java 100.00% <0.00%> (ø) 2.00% <0.00%> (-2.00%)
...eedu/address/logic/parser/RemindCommandParser.java 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
...ava/seedu/address/logic/commands/CommandLogic.java 84.61% <0.00%> (ø) 9.00% <0.00%> (?%)
...va/seedu/address/logic/commands/RemindCommand.java 87.87% <0.00%> (+2.16%) 10.00% <0.00%> (ø%)
...in/java/seedu/address/logic/parser/ParserUtil.java 74.00% <0.00%> (+2.57%) 15.00% <0.00%> (+2.00%)
...va/seedu/address/logic/commands/DeleteCommand.java 100.00% <0.00%> (+7.14%) 7.00% <0.00%> (-8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8751dc7...3aacdec. Read the comment docs.

Copy link

@andreatanky andreatanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@hyngkng hyngkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was at first worried about nested loops but figured there isn't a much better way anyways

@ChooJiaXin
Copy link
Collaborator Author

LGTM! I was at first worried about nested loops but figured there isn't a much better way anyways

I refactored the code so that the nesting isn't that bad and made the code neater :)

@ChooJiaXin ChooJiaXin merged commit c6e1cea into AY2021S1-CS2103T-F11-3:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request type.Task Our task to complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify task list to remove overdue tasks automatically
4 participants