Add remind command #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChooJiaXin
requested review from
itsjerryho,
hyngkng,
andreatanky and
nevirmc
itsjerryho
reviewed
Oct 5, 2020
| @@ -98,8 +99,9 @@ private static Person createEditedPerson(Person personToEdit, EditPersonDescript | |||
| Email updatedEmail = editPersonDescriptor.getEmail().orElse(personToEdit.getEmail()); | |||
| Address updatedAddress = editPersonDescriptor.getAddress().orElse(personToEdit.getAddress()); | |||
| Set<Tag> updatedTags = editPersonDescriptor.getTags().orElse(personToEdit.getTags()); | |||
| Remind updatedRemind = personToEdit.getRemind(); | |||
There was a problem hiding this comment.
just wondering, do we need an editPersonDescriptor at this stage or later?
There was a problem hiding this comment.
Since we are probably going to be adding an edit feature in the future we can just leave it in first or add it to v1.2 since the implementation is all done for us already :D
andreatanky
approved these changes
Oct 7, 2020
|
|
||
| Assignment assignment = new Assignment(name, deadline, moduleCode); | ||
|
|
||
| Assignment assignment = new Assignment(name, deadline, moduleCode, remind); |
There was a problem hiding this comment.
What do you mean?
nevirmc
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5
Ui for reminders not yet implemented.