Replace Deadline class with Time class #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChooJiaXin
reviewed
Nov 3, 2020
Comment on lines
12
to
15
| * Represents the deadline of an assignment in the assignment list. | ||
| * Guarantees: immutable; is valid as declared in {@link #isValidDeadline(String)} | ||
| */ | ||
| public class Deadline { | ||
| public class Time { |
There was a problem hiding this comment.
The JavaDocs of the Time class should be changed to match the new name.
Maybe something like:
"Represents the time found in a task in ProductiveNUS
Guarantees: immutable; is valid as decalred in {@link #isValidTime(String)"}
It would be ideal if isValidDeadline is changed to isValidTime as well, though if only the assignment class uses isValidDeadline, then it may be fine to leave the name as it is.
There was a problem hiding this comment.
okay thank you!!
src/main/java/seedu/tasklist/ui/AssignmentCardWithSchedule.java
Outdated
Show resolved
Hide resolved
# Conflicts: # docs/UserGuide.md # src/main/java/seedu/address/logic/commands/DoneCommand.java # src/main/java/seedu/address/logic/commands/EditCommand.java # src/main/java/seedu/address/logic/commands/ListCommand.java # src/main/java/seedu/address/logic/commands/PrioritizeCommand.java # src/main/java/seedu/address/logic/commands/RemindCommand.java # src/main/java/seedu/address/logic/commands/ScheduleCommand.java # src/main/java/seedu/address/logic/commands/UndoneCommand.java # src/main/java/seedu/address/logic/commands/UnprioritizeCommand.java # src/main/java/seedu/address/logic/commands/UnremindCommand.java # src/main/java/seedu/address/logic/commands/UnscheduleCommand.java # src/main/java/seedu/address/logic/parser/AddCommandParser.java # src/main/java/seedu/address/logic/parser/ParserUtil.java # src/main/java/seedu/address/logic/parser/ScheduleCommandParser.java # src/main/java/seedu/address/model/ProductiveNus.java # src/main/java/seedu/address/model/assignment/Assignment.java # src/main/java/seedu/address/model/assignment/Schedule.java # src/main/java/seedu/address/model/lesson/Lesson.java # src/main/java/seedu/address/model/task/Deadline.java # src/main/java/seedu/address/model/task/Time.java # src/main/java/seedu/address/model/util/SampleDataUtil.java # src/main/java/seedu/address/storage/JsonAdaptedAssignment.java # src/main/java/seedu/address/storage/JsonAdaptedLesson.java # src/main/java/seedu/address/timetable/TimetableRetriever.java # src/main/java/seedu/address/ui/AssignmentCard.java # src/main/java/seedu/address/ui/AssignmentCardWithSchedule.java # src/main/java/seedu/address/ui/UpcomingLessonCard.java # src/main/java/seedu/address/ui/UpcomingTaskListPanel.java # src/main/java/seedu/tasklist/model/task/Deadline.java # src/test/java/seedu/address/logic/commands/ListCommandTest.java # src/test/java/seedu/address/logic/parser/AddCommandParserTest.java # src/test/java/seedu/address/logic/parser/EditCommandParserTest.java # src/test/java/seedu/address/logic/parser/ParserUtilTest.java # src/test/java/seedu/address/model/task/DeadlineTest.java # src/test/java/seedu/address/model/task/TimeTest.java # src/test/java/seedu/address/storage/JsonAdaptedAssignmentTest.java # src/test/java/seedu/address/testutil/AssignmentBuilder.java # src/test/java/seedu/address/testutil/EditAssignmentDescriptorBuilder.java # src/test/java/seedu/address/testutil/LessonBuilder.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.