Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Person to assignment #65

Merged
merged 38 commits into from
Oct 6, 2020
Merged

Person to assignment #65

merged 38 commits into from
Oct 6, 2020

Conversation

nevirmc
Copy link
Collaborator

@nevirmc nevirmc commented Oct 4, 2020

No description provided.

ChooJiaXin and others added 21 commits September 25, 2020 01:47
@ChooJiaXin
Replace Phone to Deadline
b144761
@andreatanky
Fix checkStyle errors
e0eff0d
@andreatanky
Add module field
7158732
@andreatanky
Add module code field v2.0
b56aa74
@andreatanky
Merge branch 'master' into branch-AddAModuleField
16ad760
@ChooJiaXin
Implement parser to parse valid deadlines in the appropriate format
64125f7
@ChooJiaXin
Add JUnit testing
edb3016
@ChooJiaXin
Merge branch 'master' into branch-change-phone-to-deadline
e24b0fb
@andreatanky
Update all address fields
57429b7
@ChooJiaXin
Edit DateTime format
ff4bf3e
@andreatanky
Change regex to match module code
f6e9f28
@andreatanky
Change tests
5f1c547
@andreatanky
Updated test cases and regex
8918c18
@andreatanky
Merge remote-tracking branch 'origin/branch-AddAModuleField' into bra…
104730e 
…nch-AddAModuleField
@andreatanky
Update comments and test cases
6ab508f
@andreatanky
Change address comments
525b08f
@andreatanky
Add more test cases
072c945
@andreatanky
Update moduleCode class
025879d
@nevirmc
Change person to assignment
bf94f65
@nevirmc
no message
f45b128
@nevirmc
Fix checkstyle
9e5e07d
@nevirmc nevirmc linked an issue Oct 4, 2020 that may be closed by this pull request
Change name of Person class to Assignment #43
Closed
@nevirmc nevirmc self-assigned this Oct 4, 2020
ChooJiaXin and others added 4 commits October 4, 2020 22:13
@ChooJiaXin ChooJiaXin added this to the v1.2 milestone Oct 4, 2020
ChooJiaXin
ChooJiaXin reviewed Oct 4, 2020
View reviewed changes
Copy link
Collaborator

@ChooJiaXin ChooJiaXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. Otherwise, looking good :)

src/main/java/seedu/address/logic/Logic.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/ReadOnlyAddressBook.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/person/Assignment.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/person/UniqueAssignmentList.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/person/exceptions/DuplicateAssignmentException.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/storage/JsonSerializableAddressBook.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/ui/AssignmentListPanel.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/model/person/UniqueAssignmentListTest.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/model/person/UniqueAssignmentListTest.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/testutil/TypicalAssignments.java Outdated Show resolved Hide resolved
ChooJiaXin
ChooJiaXin reviewed Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@ChooJiaXin ChooJiaXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits on code quality. Otherwise, looks good :)

src/main/java/seedu/address/storage/JsonAdaptedAssignment.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/model/person/UniqueAssignmentListTest.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/model/person/UniqueAssignmentListTest.java Outdated Show resolved Hide resolved
hyngkng
hyngkng reviewed Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@hyngkng hyngkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a great job of creating the tests. I agree with Jia Xin's comments on coding style and readability. Apart from that, LGTM!

ChooJiaXin
ChooJiaXin approved these changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@ChooJiaXin ChooJiaXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. Otherwise, LGTM :)

src/main/java/seedu/address/logic/parser/ParserUtil.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/testutil/AssignmentBuilder.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/person/UniqueAssignmentList.java Outdated Show resolved Hide resolved
@nevirmc nevirmc merged commit 2701a53 into AY2021S1-CS2103T-F11-3:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyngkng hyngkng hyngkng left review comments

@ChooJiaXin ChooJiaXin ChooJiaXin approved these changes

Assignees

@nevirmc nevirmc

Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Change name of Person class to Assignment
5 participants
@nevirmc @hyngkng @ChooJiaXin @andreatanky @itsjerryho