Add lesson class and fields #68
Conversation
| // valid name | ||
| assertTrue(LessonName.isValidLessonName("Lecture")); // alphabets only | ||
| assertTrue(LessonName.isValidLessonName("Tutorial")); // numbers only | ||
| assertTrue(LessonName.isValidLessonName("Laboratory")); // alphanumeric characters | ||
| assertTrue(LessonName.isValidLessonName("Recitation")); // with capital letters | ||
| assertTrue(LessonName.isValidLessonName("Sectional Teachings")); // long names |
There was a problem hiding this comment.
The test cases look good! Minor nitpick, the comments next to the valid test cases do not match what is being tested. Also, if the lesson names do not accept numerals in the name, you may want to consider changing the validation regex to only accept alphabets :)
There was a problem hiding this comment.
I removed these tests because Assignment already tests Name. :) Thanks!
| assertFalse(Time.isValidDeadline("1200 1999-10-10")); // invalid time | ||
|
|
| import static seedu.address.commons.util.AppUtil.checkArgument; | ||
|
|
||
| /** | ||
| * Represents an assignment's module code in the address book. |
There was a problem hiding this comment.
Perhaps comment can be changed to just 'module code'? Since it is applicable to both lessons and assignments
There was a problem hiding this comment.
Amended. Changed to Task instead. :)
| public class ModuleCode { | ||
|
|
||
| public static final String MESSAGE_CONSTRAINTS = | ||
| "Module codes should begin with 2 or 3 alphabets, have 4 numbers and end with an alphabet/number.\n" |
There was a problem hiding this comment.
I think module code might not have to end with an alphabet or number all the time right haha. maybe can phrase it '... have 4 numbers and may end with an alphabet.'
| public Lesson(Name name, Deadline deadline, ModuleCode moduleCode) { | ||
| super(name, deadline, moduleCode); | ||
| requireAllNonNull(name, deadline, moduleCode); | ||
| } | ||
|
|
||
| public Deadline getDeadline() { | ||
| return super.getTime(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Naming the deadline field time may be more appropriate for the Lesson class as it doesn't really make sense for a Lesson to have a deadline.
No description provided.