Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update help window contents #117

Merged
merged 6 commits into from
Oct 9, 2020
Merged

Update help window contents #117

merged 6 commits into from
Oct 9, 2020

Conversation

qwoprocks
Copy link
Member

Fixes #79

@qwoprocks qwoprocks added the type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new label Oct 6, 2020
@qwoprocks qwoprocks added this to the v1.2 milestone Oct 6, 2020
@qwoprocks qwoprocks requested a review from rtshkmr October 6, 2020 04:26
@qwoprocks qwoprocks self-assigned this Oct 6, 2020
@qwoprocks qwoprocks added this to In progress in v1.2 via automation Oct 6, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #117 into master will decrease coverage by 0.29%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #117      +/-   ##
============================================
- Coverage     72.01%   71.72%   -0.30%     
  Complexity      400      400              
============================================
  Files            75       75              
  Lines          1233     1238       +5     
  Branches        124      124              
============================================
  Hits            888      888              
- Misses          313      318       +5     
  Partials         32       32
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/HelpWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/UiManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5660ec...9a080e1. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Oct 9, 2020 •
edited

Codecov Report

Merging #117 into master will decrease coverage by 0.28%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #117      +/-   ##
============================================
- Coverage     72.38%   72.10%   -0.29%     
  Complexity      410      410              
============================================
  Files            76       76              
  Lines          1264     1269       +5     
  Branches        127      127              
============================================
  Hits            915      915              
- Misses          315      320       +5     
  Partials         34       34
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/HelpWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/UiManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb9c674...49ebcfd. Read the comment docs.

tankangliang
tankangliang approved these changes Oct 9, 2020
View reviewed changes
Copy link

@tankangliang tankangliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help window opens up fine. LGTM

v1.2 automation moved this from In progress to Reviewer approved Oct 9, 2020
@qwoprocks qwoprocks merged commit 725bbec into AY2021S1-CS2103T-F11-4:master Oct 9, 2020
v1.2 automation moved this from Reviewer approved to Done Oct 9, 2020
@tankangliang tankangliang mentioned this pull request Oct 12, 2020
Closed
@tankangliang tankangliang linked an issue Oct 12, 2020 that may be closed by this pull request
As a new user I can use a “help” command #88
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tankangliang tankangliang tankangliang approved these changes

@rtshkmr rtshkmr Awaiting requested review from rtshkmr

Assignees

@qwoprocks qwoprocks

Labels
type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
No open projects
v1.2
Done
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

As a new user I can use a “help” command Update help window contents
4 participants
@qwoprocks @codecov-commenter @codecov-io @tankangliang