Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkstyle.xml to check public classes for javadoc comments #128

Merged
merged 3 commits into from
Oct 11, 2020

Conversation

qwoprocks
Copy link
Member

No description provided.

Copy link

@tankangliang tankangliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #128 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #128   +/-   ##
=========================================
  Coverage     71.28%   71.28%           
  Complexity      440      440           
=========================================
  Files            81       81           
  Lines          1379     1379           
  Branches        143      143           
=========================================
  Hits            983      983           
  Misses          345      345           
  Partials         51       51           
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/model/note/Note.java 75.00% <ø> (ø) 2.00 <0.00> (ø)
.../main/java/seedu/address/model/tag/TagFactory.java 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c574e5c...52d6bfa. Read the comment docs.

@qwoprocks qwoprocks merged commit 7829ecf into AY2021S1-CS2103T-F11-4:master Oct 11, 2020
@qwoprocks qwoprocks deleted the update-checkstyle branch October 11, 2020 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants