Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new workflow that automatically generates and commits UML pngs #135

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Create new workflow that automatically generates and commits UML pngs #135

merged 2 commits into from
Oct 12, 2020

Conversation

qwoprocks
Copy link
Member

@qwoprocks qwoprocks commented Oct 11, 2020 •
edited

Workflow is only triggered when changes are made to the .puml files in the docs/diagrams directory.

Tested on my own branch, works well.

@qwoprocks qwoprocks added the type.Admin Administrative tasks and repository related issues label Oct 11, 2020
@qwoprocks qwoprocks self-assigned this Oct 11, 2020
tankangliang
tankangliang approved these changes Oct 11, 2020
View reviewed changes
Copy link

@tankangliang tankangliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LeeEnHao
LeeEnHao approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@LeeEnHao LeeEnHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it

raysonkoh
raysonkoh reviewed Oct 11, 2020
View reviewed changes
Copy link

@raysonkoh raysonkoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #135   +/-   ##
=========================================
  Coverage     70.38%   70.38%           
  Complexity      471      471           
=========================================
  Files            87       87           
  Lines          1506     1506           
  Branches        151      151           
=========================================
  Hits           1060     1060           
  Misses          391      391           
  Partials         55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 968ac5e...7ff597b. Read the comment docs.

rtshkmr
rtshkmr approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@rtshkmr rtshkmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@qwoprocks qwoprocks merged commit 6c4e9ad into AY2021S1-CS2103T-F11-4:master Oct 12, 2020
@qwoprocks qwoprocks deleted the plantuml-action branch October 12, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raysonkoh raysonkoh raysonkoh left review comments

@tankangliang tankangliang tankangliang approved these changes

@rtshkmr rtshkmr rtshkmr approved these changes

@LeeEnHao LeeEnHao LeeEnHao approved these changes

Assignees

@qwoprocks qwoprocks

Labels
type.Admin Administrative tasks and repository related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@qwoprocks @codecov-io @tankangliang @raysonkoh @rtshkmr @LeeEnHao