Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to include country and timezone #139

Merged

Conversation

tankangliang
Copy link

@tankangliang tankangliang commented Oct 12, 2020

Description

client edit is now working with timezone and country fields. Tests have been updated to include changes in country and timezone. Tests are also added for Timezone.

Fixes #78 #81 #84

Testing

Initial state of application:
client add n/Name1 e/email@gmail.com p/911 a/Address c/SG tz/GMT-12
client add n/Name2 e/email2@gmail.com p/922 a/Address c/SG tz/GMT+12

Commands ran in order:

  1. client edit 1 c/MY -> Client "Name1" now has country Malaysia
  2. client edit 2 c/JP -> Client "Name2" now has country Japan
  3. client edit 1 tz/GMT+5 Client "Name1" now has country Msia and timezone GMT+5
  4. client edit 2 tz/GMT-5 Client "Name2" now has country Japan and timezone GMT-5

Remarks

nil

@tankangliang tankangliang added the type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new label Oct 12, 2020
@tankangliang tankangliang added this to In progress in v1.2 via automation Oct 12, 2020
@tankangliang tankangliang linked an issue Oct 12, 2020 that may be closed by this pull request
@tankangliang tankangliang added this to the v1.2 milestone Oct 12, 2020
@codecov-io
Copy link

codecov-io commented Oct 13, 2020

Codecov Report

Merging #139 into master will increase coverage by 0.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #139      +/-   ##
============================================
+ Coverage     70.99%   71.41%   +0.42%     
- Complexity      519      523       +4     
============================================
  Files            90       90              
  Lines          1665     1665              
  Branches        171      171              
============================================
+ Hits           1182     1189       +7     
+ Misses          421      418       -3     
+ Partials         62       58       -4     
Impacted Files Coverage Δ Complexity Δ
...eedu/address/logic/commands/ClientEditCommand.java 94.93% <100.00%> (ø) 12.00 <0.00> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 51.02% <100.00%> (ø) 14.00 <0.00> (ø)
...ddress/logic/parser/ClientDeleteCommandParser.java 100.00% <100.00%> (ø) 2.00 <1.00> (?)
.../address/logic/parser/ClientFindCommandParser.java 100.00% <100.00%> (ø) 3.00 <1.00> (?)
...in/java/seedu/address/logic/parser/ParserUtil.java 94.11% <0.00%> (+3.92%) 19.00% <0.00%> (+1.00%)
...main/java/seedu/address/model/client/Timezone.java 86.36% <0.00%> (+22.72%) 10.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 037990d...6bff4d1. Read the comment docs.

@tankangliang tankangliang linked an issue Oct 13, 2020 that may be closed by this pull request
Copy link

@raysonkoh raysonkoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

v1.2 automation moved this from In progress to Reviewer approved Oct 14, 2020
@tankangliang tankangliang merged commit 4a35d94 into AY2021S1-CS2103T-F11-4:master Oct 14, 2020
v1.2 automation moved this from Reviewer approved to Done Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
No open projects
v1.2
Done
4 participants