-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests to include country and timezone #139
Update tests to include country and timezone #139
Conversation
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
============================================
+ Coverage 70.99% 71.41% +0.42%
- Complexity 519 523 +4
============================================
Files 90 90
Lines 1665 1665
Branches 171 171
============================================
+ Hits 1182 1189 +7
+ Misses 421 418 -3
+ Partials 62 58 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
client edit
is now working with timezone and country fields. Tests have been updated to include changes in country and timezone. Tests are also added forTimezone
.Fixes #78 #81 #84
Testing
Initial state of application:
client add n/Name1 e/email@gmail.com p/911 a/Address c/SG tz/GMT-12
client add n/Name2 e/email2@gmail.com p/922 a/Address c/SG tz/GMT+12
Commands ran in order:
client edit 1 c/MY
-> Client "Name1" now has country Malaysiaclient edit 2 c/JP
-> Client "Name2" now has country Japanclient edit 1 tz/GMT+5
Client "Name1" now has country Msia and timezone GMT+5client edit 2 tz/GMT-5
Client "Name2" now has country Japan and timezone GMT-5Remarks
nil