Change CSS to match theme in README #164

LeeEnHao · 2020-10-15T14:04:31Z

Description

Change CSS: slight modifications to existing CSS classes.
Result display reverted back to rectangle. Reason unable to change scroll pane background color, which will be exposed if content has a round radius.

Fixes #124

Testing

Manual Testing

Change result display message.
Result display unable to implement border radius property without switching away from TextArea to TextField.
- Using TextField causes text to be un-scrollable if result message is too long.
Test suites for all ui components in separate pr

Remarks

Add any additional remarks for others to take note of.

codecov-io · 2020-10-15T14:06:11Z

Codecov Report

Merging #164 into master will decrease coverage by 1.04%.
The diff coverage is 24.70%.

@@             Coverage Diff              @@
##             master     #164      +/-   ##
============================================
- Coverage     74.22%   73.18%   -1.05%     
- Complexity      616      625       +9     
============================================
  Files            96       97       +1     
  Lines          1905     1939      +34     
  Branches        207      208       +1     
============================================
+ Hits           1414     1419       +5     
- Misses          425      446      +21     
- Partials         66       74       +8

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/seedu/address/MainApp.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...in/java/seedu/address/commons/core/LogsCenter.java	`78.37% <ø> (ø)`	`10.00 <0.00> (ø)`
src/main/java/seedu/address/ui/MainWindow.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
src/main/java/seedu/address/ui/TextClock.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
src/main/java/seedu/address/ui/WidgetViewBox.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
.../java/seedu/address/model/widget/WidgetObject.java	`38.46% <10.00%> (+6.20%)`	`14.00 <9.00> (+8.00)`
...seedu/address/model/widget/WidgetModelManager.java	`52.17% <63.63%> (-0.46%)`	`6.00 <4.00> (+1.00)`	⬇️
...va/seedu/address/logic/commands/CommandResult.java	`84.21% <75.00%> (-4.03%)`	`10.00 <2.00> (ø)`
...eedu/address/logic/commands/ClientViewCommand.java	`100.00% <100.00%> (ø)`	`7.00 <0.00> (ø)`
...java/seedu/address/logic/commands/ExitCommand.java	`100.00% <100.00%> (ø)`	`2.00 <1.00> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b421520...0c07d00. Read the comment docs.

LeeEnHao · 2020-10-19T13:11:43Z

Please pull this down and test it locally. Especially on Ubuntu or macOs.

…o view-gui-feature

qwoprocks

UI overall works as expected, just that the default message with div1 div2 can be seen at certain points of the program, such as when you run the app and type list.

Also, the view window doesn't update when you execute more commands, for example if I type client view 1 then client note add ..., or client edit ..., the view part doesn't reflect the changes.

src/main/java/seedu/address/MainApp.java

src/main/java/seedu/address/model/widget/WidgetModelManager.java

src/main/resources/view/DarkTheme.css

src/main/resources/view/HelpWindow.fxml

src/test/java/seedu/address/model/widget/WidgetModelManagerTest.java

build.gradle

src/main/java/seedu/address/model/widget/WidgetModelManager.java

src/main/java/seedu/address/model/widget/WidgetObject.java

src/main/resources/view/DarkTheme.css

List command re renders the view box. Fix implemented: In line with the original implementation that some command results which have a direct interaction with the view have a boolean getter, view commands now has a boolean value view to indicate to the view that the viewbox has to be updated/re-rendered

…into view-gui-feature

Add runtime dependency; junit jupiter engine. Removed rendering of client notes from widget view box. Reduced border radius of client list view and widget to reduce contrast with the command result display box.

LeeEnHao · 2020-10-20T12:07:03Z

UI overall works as expected, just that the default message with div1 div2 can be seen at certain points of the program, such as when you run the app and type list.

Also, the view window doesn't update when you execute more commands, for example if I type client view 1 then client note add ..., or client edit ..., the view part doesn't reflect the changes.

I'll open a new issue for that as it could possibly be a non trivial implementation. Currently, the widget only updates on the being given a view command.

qwoprocks

Just some small stuff, other than those, I think LGTM

src/main/resources/view/MainWindow.fxml

src/main/resources/view/WidgetViewBox.fxml

src/main/java/seedu/address/model/widget/WidgetModelManager.java

src/main/java/seedu/address/model/widget/WidgetObject.java

rtshkmr

LGTM for now because it's functional. Here are some point pointers to take note of for a follow up PR:

relevant people need to update the help window (command description). also help window should have some sort of scrollbar/diff dimensions cuz the command list gonna be long for the current dimensions
fix Locale issue for default display, maybe we create a bug report for that. But leave it as is for Friday's demo. I

rtshkmr · 2020-10-21T11:03:05Z

src/main/java/seedu/address/ui/TextClock.java

+    /**
+     * Stops the clock.
+     */
+    public void stop() {


This is an unused method for now, can't see where else it's used..

rtshkmr · 2020-10-21T11:04:39Z

src/main/java/seedu/address/ui/WidgetViewBox.java

+        textThree.setText("");
+        divThree.setText("");
+        textFour.setText("");
+        footer.setText("Made in NUS");


Footer should probably be lowered to the bottom border right.

But fixing this isn't that impt for now since it's functional!

Changed

LeeEnHao force-pushed the view-gui-feature branch 4 times, most recently from 4881205 to 2612e2a Compare October 18, 2020 18:09

LeeEnHao marked this pull request as ready for review October 18, 2020 18:13

LeeEnHao requested a review from qwoprocks October 18, 2020 19:25

Change GUI theme

f8d7d7e

LeeEnHao force-pushed the view-gui-feature branch from 36ffaac to f8d7d7e Compare October 19, 2020 02:42

Merge branch 'master' into view-gui-feature

10b02a0

LeeEnHao requested review from raysonkoh, rtshkmr and tankangliang October 19, 2020 13:09

LeeEnHao added 2 commits October 19, 2020 21:24

Move clock component to another class

984646d

Merge branch 'view-gui-feature' of https://github.com/LeeEnHao/tp int…

3474350

…o view-gui-feature

qwoprocks requested changes Oct 20, 2020

View reviewed changes

raysonkoh reviewed Oct 20, 2020

View reviewed changes

LeeEnHao added 11 commits October 20, 2020 15:12

Fixes in build.gradle

0c8f6c7

Fix nits in logger info message

0e3cfe8

Remove logger info from testing

9c3ad82

Remove all preceding space from self closing tags

dadf1eb

Merge branch 'master' of https://github.com/AY2021S1-CS2103T-F11-4/tp …

3d0a09f

…into view-gui-feature

Removed todo

1c3f3d0

Update

95159f7

Merge branch 'master' of https://github.com/AY2021S1-CS2103T-F11-4/tp …

d82b32e

…into view-gui-feature

Add scrollbar thumb

fae563e

Minor fixes

796f947

Add runtime dependency; junit jupiter engine. Removed rendering of client notes from widget view box. Reduced border radius of client list view and widget to reduce contrast with the command result display box.

LeeEnHao self-assigned this Oct 20, 2020

Add nit fixes

02c207a

LeeEnHao force-pushed the view-gui-feature branch from cb81601 to 02c207a Compare October 20, 2020 12:30

LeeEnHao requested a review from qwoprocks October 20, 2020 12:33

Merge branch 'master' into view-gui-feature

d628f2d

qwoprocks previously requested changes Oct 20, 2020

View reviewed changes

LeeEnHao added 6 commits October 20, 2020 23:48

Fix indentation

5f5d043

Fix typo

8a19bb6

Change format

708870d

Fix indentation

94c02b7

Change to 2 space indent as per fxml standard

8700e7e

Nit

ac25e3e

LeeEnHao requested a review from qwoprocks October 20, 2020 16:24

LeeEnHao and others added 7 commits October 21, 2020 02:02

Merge branch 'master' into view-gui-feature

017bc31

Merge branch 'master' into view-gui-feature

a5c922e

Add textarea

6ee38db

Comment out null exception

16ad318

Workarounds

0dbc70f

Add Label

11bebd3

Checkstyle fix

974df12

rtshkmr approved these changes Oct 21, 2020

View reviewed changes

LeeEnHao removed request for tankangliang and qwoprocks October 21, 2020 11:27

Inline variable

0c07d00

LeeEnHao merged commit ebe5f29 into AY2021S1-CS2103T-F11-4:master Oct 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change CSS to match theme in README #164

Change CSS to match theme in README #164

LeeEnHao commented Oct 15, 2020 •

edited

codecov-io commented Oct 15, 2020 •

edited by codecov bot

LeeEnHao commented Oct 19, 2020

qwoprocks left a comment

LeeEnHao commented Oct 20, 2020

qwoprocks left a comment

rtshkmr left a comment

rtshkmr Oct 21, 2020

rtshkmr Oct 21, 2020 •

edited

Change CSS to match theme in README #164

Change CSS to match theme in README #164

Conversation

LeeEnHao commented Oct 15, 2020 • edited

Description

Testing

Remarks

codecov-io commented Oct 15, 2020 • edited by codecov bot

Codecov Report

LeeEnHao commented Oct 19, 2020

qwoprocks left a comment

Choose a reason for hiding this comment

LeeEnHao commented Oct 20, 2020

qwoprocks left a comment

Choose a reason for hiding this comment

rtshkmr left a comment

Choose a reason for hiding this comment

rtshkmr Oct 21, 2020

Choose a reason for hiding this comment

rtshkmr Oct 21, 2020 • edited

Choose a reason for hiding this comment

LeeEnHao commented Oct 15, 2020 •

edited

codecov-io commented Oct 15, 2020 •

edited by codecov bot

rtshkmr Oct 21, 2020 •

edited