-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagrams to developer guide #207
Add diagrams to developer guide #207
Conversation
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
=========================================
Coverage 75.80% 75.80%
Complexity 678 678
=========================================
Files 99 99
Lines 1992 1992
Branches 212 212
=========================================
Hits 1510 1510
Misses 409 409
Partials 73 73 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for small issue
:Add related predicate into list; | ||
:Add related comparator into list; | ||
endwhile | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should have a [else]
Description
Add new diagrams to developer guide under Implementation.