Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagrams to developer guide #207

Merged

Conversation

tankangliang
Copy link

Description

Add new diagrams to developer guide under Implementation.

@tankangliang tankangliang added the type.documentation Improvements or additions to documentation label Oct 22, 2020
@tankangliang tankangliang added this to In progress in v1.3 via automation Oct 22, 2020
@tankangliang tankangliang added this to the v1.3 milestone Oct 22, 2020
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #207 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #207   +/-   ##
=========================================
  Coverage     75.80%   75.80%           
  Complexity      678      678           
=========================================
  Files            99       99           
  Lines          1992     1992           
  Branches        212      212           
=========================================
  Hits           1510     1510           
  Misses          409      409           
  Partials         73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00bb3cd...2d1b7c7. Read the comment docs.

v1.3 automation moved this from In progress to Reviewer approved Oct 22, 2020
Copy link
Member

@qwoprocks qwoprocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for small issue

:Add related predicate into list;
:Add related comparator into list;
endwhile

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have a [else]

@tankangliang tankangliang merged commit 5d815aa into AY2021S1-CS2103T-F11-4:master Oct 22, 2020
v1.3 automation moved this from Reviewer approved to Done Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.documentation Improvements or additions to documentation
Projects
No open projects
v1.3
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants