Update note card and other CSS #247
Conversation
qwoprocks
added
type.Task
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
============================================
- Coverage 84.61% 84.44% -0.17%
- Complexity 851 864 +13
============================================
Files 110 110
Lines 2320 2372 +52
Branches 255 263 +8
============================================
+ Hits 1963 2003 +40
- Misses 271 280 +9
- Partials 86 89 +3
Continue to review full report at Codecov.
|
| @@ -9,7 +9,9 @@ | |||
| */ | |||
| public class Tag { | |||
|
|
|||
| public static final String MESSAGE_CONSTRAINTS = "Tags names should be alphanumeric"; | |||
| public static final int MAX_CHARACTERS = 45; | |||
| public static final String MESSAGE_CONSTRAINTS = "Tags names should be alphanumeric and be within " + MAX_CHARACTERS | |||
There was a problem hiding this comment.
Maybe rephrase to "maximum of 45 characters" instead of "be within 45 characters"?
| @FXML | ||
| private Label header; | ||
| @FXML | ||
| private ListView<CountryNote> countryNoteListView; | ||
| private VBox countryNoteListView; |
There was a problem hiding this comment.
Should this be countryListView since the subpanel contains a countryNoteListView?
There was a problem hiding this comment.
This one is being used to display country notes if we're looking at one country only, so I just left it as countryNoteListView
good catch, I'll add it as an issue |
Description
Fixes #217, fixes #250
Changes (view ss below for reference):
Testing
Ran all test, passed all tests.
Ran the following commands:
country note delete 2country note add c/US nt/blahblahabalmecor ncomncountry note view c/UScountry note delete 1client edit 1 t/pneumonoultramicroscopicsilicovolcanoconiosis(success)client edit 1 t/pneumonoultramicroscopicsilicovolcanoconiosism(fail)client add n/mmm p/901 e/m@c.com a/bac,lem c/SG tz/GMT+9 t/pneumonoultramicroscopicsilicovolcanoconiosis t/pneumonoultramicroscopicsilicovolcanoconiosimmm(fail)client add n/mmm p/901 e/m@c.com a/bac,lem c/SG tz/GMT+9 t/pneumonoultramicroscopicsilicovolcanoconiosis t/pneumonoultramicroscopicsilicovolcanoconios(success)Remarks
Not sure if we want to use the same way for clients as I did for notes (refer to point 3 of changes). @tankangliang @raysonkoh @rtshkmr @LeeEnHao what do y'all think? The current listview has buggy behavior with scrolling, if you have one cell that's much longer than the others, the scrollbar gets smaller when that cell is rendered, and then bigger again as you scroll on. Its most obvious when you click and drag the scrollbar.