Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client tags and add more tests for parsing #249

Conversation

tankangliang
Copy link

Description

Removed tags field from Client

Fixes #248
Related: #230

Testing

All tests are passing as usual.

Updated test to reflect changes to country commands and a little bit of standardization in format.

@tankangliang tankangliang added the priority.High Must do label Oct 27, 2020
@tankangliang tankangliang added this to In progress in v1.3 via automation Oct 27, 2020
@tankangliang tankangliang added this to the v1.3 milestone Oct 27, 2020
@tankangliang tankangliang linked an issue Oct 27, 2020 that may be closed by this pull request
@tankangliang tankangliang self-assigned this Oct 27, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #249 into master will decrease coverage by 0.07%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #249      +/-   ##
============================================
- Coverage     84.44%   84.37%   -0.08%     
+ Complexity      864      851      -13     
============================================
  Files           110      110              
  Lines          2372     2310      -62     
  Branches        263      253      -10     
============================================
- Hits           2003     1949      -54     
+ Misses          280      276       -4     
+ Partials         89       85       -4     
Impacted Files Coverage Δ Complexity Δ
...seedu/address/logic/commands/ClientAddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...u/address/logic/parser/ClientAddCommandParser.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
.../address/logic/parser/ClientEditCommandParser.java 100.00% <ø> (+6.25%) 10.00 <0.00> (-4.00) ⬆️
src/main/java/seedu/address/model/AddressBook.java 86.36% <ø> (-3.30%) 20.00 <0.00> (-3.00)
.../java/seedu/address/model/util/SampleDataUtil.java 92.30% <ø> (-3.15%) 7.00 <0.00> (-1.00)
...seedu/address/model/widget/WidgetModelManager.java 46.34% <ø> (-5.84%) 6.00 <0.00> (ø)
src/main/java/seedu/address/ui/ClientListCard.java 95.45% <ø> (-0.55%) 6.00 <0.00> (-2.00)
...eedu/address/logic/commands/ClientEditCommand.java 93.82% <50.00%> (-0.43%) 12.00 <0.00> (ø)
...c/main/java/seedu/address/model/client/Client.java 98.36% <100.00%> (-0.22%) 30.00 <1.00> (-3.00)
.../java/seedu/address/storage/JsonAdaptedClient.java 100.00% <100.00%> (ø) 20.00 <0.00> (-1.00)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1beeb1...6f6de67. Read the comment docs.

Copy link
Member

@qwoprocks qwoprocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issues, other than that LGTM, also there's a tagged field left in duplicateClientAddressBook.json

v1.3 automation moved this from In progress to Reviewer approved Oct 27, 2020
@tankangliang tankangliang merged commit 4121111 into AY2021S1-CS2103T-F11-4:master Oct 27, 2020
v1.3 automation moved this from Reviewer approved to Done Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v1.3
Done
Development

Successfully merging this pull request may close these issues.

Remove "tags" field from Client Increase test coverage for logic
2 participants