-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove client tags and add more tests for parsing #249
Remove client tags and add more tests for parsing #249
Conversation
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
============================================
- Coverage 84.44% 84.37% -0.08%
+ Complexity 864 851 -13
============================================
Files 110 110
Lines 2372 2310 -62
Branches 263 253 -10
============================================
- Hits 2003 1949 -54
+ Misses 280 276 -4
+ Partials 89 85 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor issues, other than that LGTM, also there's a tagged field left in duplicateClientAddressBook.json
Description
Removed
tags
field fromClient
Fixes #248
Related: #230
Testing
All tests are passing as usual.
Updated test to reflect changes to country commands and a little bit of standardization in format.