Client Edit, Client Note Edit Bug Fixes

[rtshkmr]

Description

Bug: when editing a non-note field of clients, client note wasn't getting retained.

Fixes #264
Fixes #269
Fixes #272 <== this is a minor display bug

Status: desired behaviour is reached.

• Test method: ClientEditCommandTest#execute_changeClientName_preserveExistingClientNotes()

• desired behaviuor is seen in the json file:
  before:
  

  after command : client edit 1 n/ackerman
  

Testing

Ref to example screenshot above

Remarks

Regression Test Failure was due to the mutability issue again. The following change has been done to TypicalClients#getTypicalClients

    public static List<Client> getTypicalClients() {
        Client alice = new ClientBuilder(TypicalClients.ALICE).build();
        Client benson = new ClientBuilder(TypicalClients.BENSON).build();
        Client carl = new ClientBuilder(TypicalClients.CARL).build();
        Client daniel = new ClientBuilder(TypicalClients.DANIEL).build();
        Client elle = new ClientBuilder(TypicalClients.ELLE).build();
        Client fiona = new ClientBuilder(TypicalClients.FIONA).build();
        Client george = new ClientBuilder(TypicalClients.GEORGE).build();
        return new ArrayList<>(Arrays.asList(alice, benson, carl, daniel, elle, fiona, george));
    }

[codecov]

Codecov Report

Merging #268 into master will increase coverage by 0.14%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##             master     #268      +/-   ##
============================================
+ Coverage     87.00%   87.14%   +0.14%     
- Complexity      926      928       +2     
============================================
  Files           112      112              
  Lines          2416     2420       +4     
  Branches        278      278              
============================================
+ Hits           2102     2109       +7     
+ Misses          234      233       -1     
+ Partials         80       78       -2     

Impacted Files	Coverage Δ	Complexity Δ
...ress/logic/parser/ClientNoteEditCommandParser.java	76.19% <0.00%> (ø)	4.00 <0.00> (ø)
src/main/java/seedu/address/model/TbmManager.java	93.61% <ø> (+1.95%)	25.00 <0.00> (+1.00)
...eedu/address/logic/commands/ClientEditCommand.java	94.04% <100.00%> (+0.22%)	13.00 <1.00> (+1.00)
.../address/logic/commands/ClientNoteEditCommand.java	79.41% <100.00%> (+5.88%)	9.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java	94.78% <100.00%> (+0.09%)	43.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f615a...ec36563. Read the comment docs.

[qwoprocks]

is there anything we can do in tagnotemap that would allow us to replace a client instead of doing re-init?