-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix country note list ordering #274
Fix country note list ordering #274
Conversation
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
============================================
+ Coverage 86.62% 86.78% +0.16%
- Complexity 944 945 +1
============================================
Files 113 113
Lines 2459 2459
Branches 275 274 -1
============================================
+ Hits 2130 2134 +4
+ Misses 252 248 -4
Partials 77 77
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested country note add
and country note delete
, seems to be working as expected. So just to check, a country note will first be sorted by country code, then insertion order right?
@raysonkoh yup correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
As per title. Changed from comparing note contents, to actual added order.
Fixes #
Testing
Added and deleted some country notes.
Remarks
NIL.