Standardise Storage and Loading Order for Client Notes #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtshkmr
added
priority.Medium
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
============================================
- Coverage 87.26% 87.21% -0.05%
+ Complexity 961 958 -3
============================================
Files 113 113
Lines 2512 2510 -2
Branches 287 286 -1
============================================
- Hits 2192 2189 -3
Misses 235 235
- Partials 85 86 +1
Continue to review full report at Codecov.
|
rtshkmr
changed the title
raysonkoh
requested changes
Oct 31, 2020
| */ | ||
| public void setNotes(List<Note> notes) { | ||
| countryNotesManager.clear(); |
There was a problem hiding this comment.
This is important!! don't delete this
| @@ -61,11 +61,10 @@ public TbmManager toModelType() throws IllegalValueException { | |||
| } | |||
| tbmManager.addClient(client); | |||
| } | |||
| for (JsonAdaptedNote note: notes) { | |||
| for (JsonAdaptedNote note: countryNotes) { | |||
There was a problem hiding this comment.
Renaming note to countryNote might be clearer
There was a problem hiding this comment.
renamed to jsonAdaptedCountryNote
| "countryCode": "NULL_CC", | ||
| "tags": ["godLike"] | ||
| "countryNotes": [ { | ||
| "contents": "too hot, hot damn", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per title.
Fixes #319
Testing
NIL, just works man:
Remarks
NIL