Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fixes from Dry Run #336

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

rtshkmr
Copy link
Member

@rtshkmr rtshkmr commented Nov 4, 2020

Description

Involves the easier fixes from the Dry run.

Fixes #302 ➡️ displays "client" iff returns 1 result else return "clients".
Fixes #294 ➡️ reflects annotated diagram now.

Testing

NIL

Remarks

NIL

@rtshkmr rtshkmr self-assigned this Nov 4, 2020
@rtshkmr rtshkmr added this to In progress in v1.4 via automation Nov 4, 2020
@rtshkmr rtshkmr added this to the v1.4 milestone Nov 4, 2020
@rtshkmr rtshkmr added WIP In Progress type.Bug A bug labels Nov 4, 2020
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #336 into master will decrease coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #336      +/-   ##
============================================
- Coverage     88.37%   88.34%   -0.03%     
- Complexity      969      973       +4     
============================================
  Files           113      113              
  Lines          2529     2532       +3     
  Branches        288      289       +1     
============================================
+ Hits           2235     2237       +2     
+ Misses          208      207       -1     
- Partials         86       88       +2     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 33.33% <50.00%> (+33.33%) 4.00 <3.00> (+4.00)
...eedu/address/logic/commands/ClientFindCommand.java 100.00% <100.00%> (ø) 6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c61c1f...ec58a7a. Read the comment docs.

@rtshkmr rtshkmr added type.documentation Improvements or additions to documentation and removed WIP In Progress labels Nov 4, 2020
@rtshkmr rtshkmr marked this pull request as ready for review November 4, 2020 06:21
docs/UserGuide.md Outdated Show resolved Hide resolved
v1.4 automation moved this from In progress to Review in progress Nov 4, 2020
Co-authored-by: qwoprocks <46164638+qwoprocks@users.noreply.github.com>
@rtshkmr rtshkmr requested review from qwoprocks and removed request for tankangliang, raysonkoh and LeeEnHao November 4, 2020 06:26
v1.4 automation moved this from Review in progress to Reviewer approved Nov 4, 2020
@rtshkmr rtshkmr merged commit 12be37b into AY2021S1-CS2103T-F11-4:master Nov 4, 2020
v1.4 automation moved this from Reviewer approved to Done Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Bug A bug type.documentation Improvements or additions to documentation
Projects
No open projects
v1.4
Done
Development

Successfully merging this pull request may close these issues.

[PE-D] Response message grammatical error [PE-D] Generic Widget View Box is not referenced in the diagram.
2 participants