Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound window width height position #352

Conversation

qwoprocks
Copy link
Member

@qwoprocks qwoprocks commented Nov 6, 2020

Description

As per title. I also fixed a small bug where the default view in the widget view box could be scrolled.

Fixes #353

Testing

Tried changing the preferences.json to some ridiculous values and the display still turns out fine, according to the bounds.

Remarks

NIL.

@qwoprocks qwoprocks added type.Bug A bug severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. labels Nov 6, 2020
@qwoprocks qwoprocks added this to the v1.4 milestone Nov 6, 2020
@qwoprocks qwoprocks self-assigned this Nov 6, 2020
@qwoprocks qwoprocks added this to In progress in v1.4 via automation Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #352 into master will increase coverage by 0.09%.
The diff coverage is 88.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #352      +/-   ##
============================================
+ Coverage     88.56%   88.65%   +0.09%     
- Complexity      974      976       +2     
============================================
  Files           112      112              
  Lines          2535     2557      +22     
  Branches        293      295       +2     
============================================
+ Hits           2245     2267      +22     
  Misses          203      203              
  Partials         87       87              
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/ui/MainWindow.java 68.04% <87.50%> (+8.30%) 13.00 <3.00> (+2.00)
src/main/java/seedu/address/ui/WidgetViewBox.java 73.25% <100.00%> (+0.63%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3ab74...f2b3649. Read the comment docs.

v1.4 automation moved this from In progress to Reviewer approved Nov 6, 2020
Copy link
Member

@rtshkmr rtshkmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used this for testing, works well. Window size was restricted to the current screen size (used a multiple monitor setup where it snaps to the full size of a particular monitor)

Might want to add a logger statement to display such shenanigans happening?

image

@qwoprocks qwoprocks merged commit 9b3ab75 into AY2021S1-CS2103T-F11-4:master Nov 6, 2020
v1.4 automation moved this from Reviewer approved to Done Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. type.Bug A bug
Projects
No open projects
v1.4
Done
Development

Successfully merging this pull request may close these issues.

GUI Bug: Default View in the widget view box can be scrolled
2 participants