Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update suggest command description #355

Merged

Conversation

qwoprocks
Copy link
Member

Description

Now after executing the suggest command, the message is more detailed, in that it tells you what the args did.

Fixes #298

Testing

NIL.

Remarks

NIL.

@qwoprocks qwoprocks added the type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new label Nov 6, 2020
@qwoprocks qwoprocks added this to the v1.4 milestone Nov 6, 2020
@qwoprocks qwoprocks self-assigned this Nov 6, 2020
@qwoprocks qwoprocks added this to In progress in v1.4 via automation Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #355 into master will increase coverage by 0.61%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #355      +/-   ##
============================================
+ Coverage     89.06%   89.67%   +0.61%     
- Complexity      985      995      +10     
============================================
  Files           112      112              
  Lines          2569     2577       +8     
  Branches        300      301       +1     
============================================
+ Hits           2288     2311      +23     
+ Misses          198      181      -17     
- Partials         83       85       +2     
Impacted Files Coverage Δ Complexity Δ
...ava/seedu/address/model/client/SuggestionType.java 66.66% <50.00%> (-4.17%) 22.00 <3.00> (+3.00) ⬇️
...a/seedu/address/logic/commands/SuggestCommand.java 96.29% <100.00%> (+0.29%) 13.00 <0.00> (ø)
src/main/java/seedu/address/ui/WidgetViewBox.java 94.18% <0.00%> (+20.93%) 18.00% <0.00%> (+7.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1e9f8...a2aa1ed. Read the comment docs.

Copy link

@tankangliang tankangliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 25 to 26
public static final String CONTRACT_DESCRIPTION = "Contract expiry date: Clients whose contracts are expiring will "
+ "be shown first.";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe modify to be the same as FREQUENCY_DESCRIPTION which mentions higher up on the list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

v1.4 automation moved this from In progress to Reviewer approved Nov 6, 2020
@qwoprocks qwoprocks merged commit 32d38c2 into AY2021S1-CS2103T-F11-4:master Nov 6, 2020
v1.4 automation moved this from Reviewer approved to Done Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
No open projects
v1.4
Done
Development

Successfully merging this pull request may close these issues.

[PE-D] Vague positive message for suggest function
2 participants