Fix code quality for logic package #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwoprocks
added
type.Task
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
============================================
+ Coverage 89.54% 89.55% +0.01%
+ Complexity 996 995 -1
============================================
Files 112 112
Lines 2583 2586 +3
Branches 304 304
============================================
+ Hits 2313 2316 +3
Misses 183 183
Partials 87 87
Continue to review full report at Codecov.
|
qwoprocks
commented
Nov 7, 2020
Comment on lines
+230
to
+231
| widgetPlaceholder.getChildren().clear(); | ||
| widgetPlaceholder.getChildren().add(widgetViewBox.getRoot()); |
There was a problem hiding this comment.
Bugfix for when country note view is called followed by client list, which doesn't reset the widget display viewbox back to default, even though it should.
rtshkmr
requested changes
Nov 7, 2020
src/main/java/seedu/address/logic/commands/ClientEditCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/parser/ClientFindCommandParser.java
Outdated
Show resolved
Hide resolved
Comment on lines
+230
to
+231
| widgetPlaceholder.getChildren().clear(); | ||
| widgetPlaceholder.getChildren().add(widgetViewBox.getRoot()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per title. Also fixed a small bug where
client listorclient suggestdoesn't change the widget view box back to the default view when in country note view.Fixes #325
Testing
NIL
Remarks
NIL