-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DG Diagrams and Include TagCommand, OpenCommand Implementation #158
Update DG Diagrams and Include TagCommand, OpenCommand Implementation #158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=========================================
Coverage 63.17% 63.17%
Complexity 409 409
=========================================
Files 84 84
Lines 1355 1355
Branches 116 116
=========================================
Hits 856 856
Misses 459 459
Partials 40 40
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't really check the UML..but LGTM!
You can use "view file" at the top right corner to see the markdown file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job on changing the DG.
|
||
-------------------------------------------------------------------------------------------------------------------- | ||
|
||
## **Appendix: Instructions for manual testing** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we deleting appendix for manual testing altogether or will we add it later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we will be doing manual testing anymore. Moreover, this appendix is for us to read and probably not suitable to be included in DG.
Deleted proposed redo/undo implementations and manual UI testing instructions.