Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG Diagrams and Include TagCommand, OpenCommand Implementation #158

Merged
merged 3 commits into from
Oct 21, 2020

Conversation

luo-git
Copy link

@luo-git luo-git commented Oct 20, 2020

Deleted proposed redo/undo implementations and manual UI testing instructions.

@codecov-io
Copy link

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #158   +/-   ##
=========================================
  Coverage     63.17%   63.17%           
  Complexity      409      409           
=========================================
  Files            84       84           
  Lines          1355     1355           
  Branches        116      116           
=========================================
  Hits            856      856           
  Misses          459      459           
  Partials         40       40           
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f948f...45925a8. Read the comment docs.

@luo-git luo-git requested a review from li-s October 20, 2020 14:30
Copy link

@HynRidge HynRidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really check the UML..but LGTM!

@luo-git
Copy link
Author

luo-git commented Oct 20, 2020

Can't really check the UML..but LGTM!

You can use "view file" at the top right corner to see the markdown file.

Copy link

@anthony6401 anthony6401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job on changing the DG.


--------------------------------------------------------------------------------------------------------------------

## **Appendix: Instructions for manual testing**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we deleting appendix for manual testing altogether or will we add it later?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we will be doing manual testing anymore. Moreover, this appendix is for us to read and probably not suitable to be included in DG.

@luo-git luo-git added this to the v1.3 milestone Oct 21, 2020
@luo-git luo-git merged commit 223d40c into AY2021S1-CS2103T-F12-1:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DG to reflect the changes in HelloFile Update the UML diagrams in DG
4 participants