Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify HelpCommand to take keyword of command #186

Merged
merged 5 commits into from
Oct 27, 2020

Conversation

HynRidge
Copy link

@HynRidge HynRidge commented Oct 26, 2020

Add HelpCommandParser to parse user argument
Add MESSAGE_USAGE in ListCommand,RedoCommand,UndoCommand,ExitCommand,ClearCommand.
Add unit test for HelpCommand and HelpCommandParser

Note: Safe to merge!!

@HynRidge HynRidge linked an issue Oct 26, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #186 into master will decrease coverage by 0.28%.
The diff coverage is 54.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #186      +/-   ##
============================================
- Coverage     63.88%   63.60%   -0.29%     
- Complexity      482      487       +5     
============================================
  Files            94       95       +1     
  Lines          1595     1621      +26     
  Branches        150      151       +1     
============================================
+ Hits           1019     1031      +12     
- Misses          523      534      +11     
- Partials         53       56       +3     
Impacted Files Coverage Δ Complexity Δ
...ava/seedu/address/logic/commands/ClearCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...va/seedu/address/logic/commands/CommandResult.java 88.23% <ø> (ø) 10.00 <0.00> (ø)
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...java/seedu/address/logic/commands/FindCommand.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...java/seedu/address/logic/commands/ListCommand.java 80.00% <ø> (ø) 3.00 <0.00> (ø)
...java/seedu/address/logic/commands/OpenCommand.java 55.55% <ø> (ø) 8.00 <0.00> (ø)
...java/seedu/address/logic/commands/RedoCommand.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...ava/seedu/address/logic/commands/RetagCommand.java 88.00% <ø> (ø) 9.00 <0.00> (ø)
...java/seedu/address/logic/commands/ShowCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
.../java/seedu/address/logic/commands/TagCommand.java 73.07% <ø> (ø) 9.00 <0.00> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2be0d3...8c899f3. Read the comment docs.

# Conflicts:
#	src/main/java/seedu/address/logic/commands/HelpCommand.java
#	src/main/java/seedu/address/logic/commands/TagCommand.java
Copy link

@luo-git luo-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is quite clean. I like it. LGTM!

Edit: Thanks for cleaning up the help message format too.

@luo-git luo-git merged commit db8646b into AY2021S1-CS2103T-F12-1:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HelpCommand
3 participants