Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more testing #189

Merged
merged 17 commits into from
Oct 28, 2020
Merged

Conversation

luo-git
Copy link

@luo-git luo-git commented Oct 27, 2020

Updates some test cases

@luo-git luo-git modified the milestones: v1.3, bugs Oct 27, 2020
@luo-git luo-git added the priority.Medium Nice to have label Oct 27, 2020
@codecov-io
Copy link

Codecov Report

Merging #189 into master will increase coverage by 0.93%.
The diff coverage is 34.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #189      +/-   ##
============================================
+ Coverage     63.81%   64.75%   +0.93%     
- Complexity      505      520      +15     
============================================
  Files            97       97              
  Lines          1686     1705      +19     
  Branches        161      168       +7     
============================================
+ Hits           1076     1104      +28     
+ Misses          551      533      -18     
- Partials         59       68       +9     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/TagCommand.java 93.10% <ø> (ø) 11.00 <0.00> (ø)
...in/java/seedu/address/model/explorer/FileList.java 52.94% <11.11%> (-47.06%) 4.00 <1.00> (+1.00) ⬇️
...java/seedu/address/model/explorer/CurrentPath.java 74.07% <12.50%> (+5.65%) 7.00 <1.00> (+3.00)
...main/java/seedu/address/model/tag/FileAddress.java 61.53% <60.00%> (-8.47%) 7.00 <4.00> (+3.00) ⬇️
...ava/seedu/address/logic/commands/LabelCommand.java 100.00% <100.00%> (+12.50%) 10.00 <0.00> (+2.00)
...java/seedu/address/logic/commands/OpenCommand.java 52.94% <100.00%> (-2.62%) 7.00 <1.00> (-1.00)
...ava/seedu/address/logic/commands/RetagCommand.java 100.00% <100.00%> (+12.00%) 11.00 <0.00> (+2.00)
...java/seedu/address/logic/commands/ListCommand.java 100.00% <0.00%> (+20.00%) 5.00% <0.00%> (+2.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e9d6de...fd2012f. Read the comment docs.

Copy link

@Ma-Yueran Ma-Yueran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the huge amount of effort, the tests looks great, LGTM!

@luo-git luo-git merged commit dd583cd into AY2021S1-CS2103T-F12-1:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants